Skip to content
This repository has been archived by the owner on Jun 20, 2022. It is now read-only.

Changes to go-sawyer are breaking build #62

Closed
zhemao opened this issue Apr 26, 2014 · 3 comments
Closed

Changes to go-sawyer are breaking build #62

zhemao opened this issue Apr 26, 2014 · 3 comments

Comments

@zhemao
Copy link

zhemao commented Apr 26, 2014

Getting the following error message on go get

package github.com/lostisland/go-sawyer/mediaheader
    imports github.com/lostisland/go-sawyer/mediaheader
    imports github.com/lostisland/go-sawyer/mediaheader: cannot find package "github.com/lostisland/go-sawyer/mediaheader"

It appears that go-sawyer has changed its structure and the mediaheader folder no longer exists.

@unRob
Copy link

unRob commented Jul 19, 2014

Same here, tried to follow #59 but as a complete novice, I have no idea on what should I do.

Did you figure it out, @zhemao?

@zhemao
Copy link
Author

zhemao commented Jul 19, 2014

Tried those instructions, and they worked, but there's something to be said about playing nicely with go get. It would be much simpler to just depend on a clone of go-sawyer which is rolled back to the needed version.

owenthereal added a commit that referenced this issue Jul 29, 2014
Code changes from the latest master of lostisland/go-sawyer hasn’t been applied to octokit/go-octokit, causing compilation errors. The current approach of providing a wrapper script to bootstrap the library is confusing (see #62). It also makes using the library harder (we need to vendor to a particular commit, see https://github.com/github/hub/blob/gh/Godeps/Godeps.json#L57-L60).

Let’s point to the fork jingweno/go-sawyer for now which doesn’t include the latest breaking changes from lostisland/go-sawyer and unblock the mentioned issues.
@owenthereal
Copy link
Contributor

#64 should fix this problem

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants