This repository has been archived by the owner on Jun 20, 2022. It is now read-only.
test Assert method usage is reversed - now fixed #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue has now been fixed. |
feiranchen
changed the title
| @@ -19,6 +19,6 @@ func TestRootEmojisService_All(t *testing.T) { | |||
| assert.False(t, result.HasError()) | |||
| var penguin = "https://github.global.ssl.fastly.net/images/icons/emoji/penguin.png?v5" | |||
| var metal = "https://github.global.ssl.fastly.net/images/icons/emoji/metal.png?v5" | |||
| assert.Equal(t, penguin, emojis["penguin"]) | |||
| assert.Equal(t, metal, emojis["metal"]) | |||
| assert.Equal(t, emojis["penguin"], penguin) | |||
There was a problem hiding this comment.
I think these two were actually correct. The expected value is just in a variable for brevity.
|
Good catch. I made one comment, but the rest of the diff looks good. 👍 |
feiranchen
added a commit
that referenced
this pull request
Apr 2, 2015
test Assert method usage is reversed - now fixed
|
Merged and closed. Let me know if there's any questions! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a couple of the more recent test cases had this problem.
The error message would have the "expected" and "actual" values reversed if the tests were to break.