This repository has been archived by the owner on Jun 20, 2022. It is now read-only.
Add helpers to access the scope and rate limit headers. #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return strings.Split(r.RawAcceptedScopes(), ",") | ||
| } | ||
|
|
||
| func (r *Result) ValidScope(scope string) bool { |
There was a problem hiding this comment.
Should this logic be built into the application instead of octokit?
|
In general, LGTM. Could add some tests though. @pengwynn What do you think? |
| func (r *Result) RateLimitRemaining() int { | ||
| rate, err := strconv.Atoi(r.Response.Header.Get(rateLimitRemaining)) | ||
| if err != nil { | ||
| rate = 60 |
There was a problem hiding this comment.
This is tricky, because Enterprise, right?
There was a problem hiding this comment.
I don't remember anymore how that thing works 😆 I guess I can check the response host and set the default to 60 in the case of api.github.com
|
Thanks for the patch @calavera. 💖 I left a couple of notes. |
|
Thank you guys, I'll add some tests today. |
…valid. Add test for result helpers. Signed-off-by: David Calavera <david.calavera@gmail.com>
It's currently not rate limited. I think |
pengwynn
added a commit
that referenced
this pull request
Apr 13, 2015
Add helpers to access the scope and rate limit headers.
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.