-
Notifications
You must be signed in to change notification settings - Fork 79
Conversation
@pengwynn: Do y'all have any interest in me adding end-to-end tests for the endpoints I'm adding that actually hit the API, and that are only run conditionally based on an environment variable? |
@half-ogre Thanks for working through these. 💖 Would have gotten back sooner, but I was off the grid. ⛺
Not quite sure I follow. It looks like you've wired up tests with the same pattern the other methods use, right? |
@pengwynn This PR is ready for review.
I was talking about adding acceptance tests in addition to the unit tests, that actually hit the live API, but the friction and amount of change this would add makes this not something to talk about in the context of this PR, even if you were interested. So, never mind. :) |
👍 looking forward to these changes |
|
||
assert.False(t, result.HasError()) | ||
|
||
assert.Equal(t, 2, len(labels)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some whitespace issues in some of the tests?
@half-ogre thanks for the patch! I saw some whitespace/alignment issues (maybe mix of tabs/spaces?). Once we fix those up this looks good. 👍 |
My bad. I ran |
🍰 |
This PR adds all the label endpoints.
TODO
Testing