Add Accept header to HEAD and GET

[owenthereal]

I need to confirm this, according to the doc, Accept header should be set. But octokit.rb only set it to HEAD and GET. Should I set it on all http verbs?

/cc @technoweenie @pengwynn

[pengwynn]

We should send them for all verbs. Octokit.rb sends them on all HTTP verbs, but it does some cheating to pull the Accept and Content-Type headers from the method options hash for convenience for HEAD and GET.

This lets us do:

client.some_method :accept => "application/vnd.github.beta"

instead of:

client.some_method :headers => {:accept => "application/vnd.github.beta"}

LOL dynamic languages. 😸

[owenthereal]

Ah, ok, so Accept is not set by default for verbs other than HEAD and GET? I meant it's passed in for other verbs than HEAD and GET

[pengwynn]

No, it's set by default for all verbs here, sourced from here.

[owenthereal]

That's what I thought. Thanks for the clarification. I fixed this pull request to send Accept on all verbs 😄 8c32ab8