This repository has been archived by the owner on Jun 20, 2022. It is now read-only.
Always return *ResponseError in NewReesponseError #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it could happen that the response body can't be decoded and the return error is a different type from *ResponseError. This causes downstream usage to handle different types of errors. The solution is to always return *ResponseError and make the decoding error as part of the *ResponseError.
|
👍 |
owenthereal
added a commit
that referenced
this pull request
Feb 23, 2014
Always return *ResponseError in NewReesponseError
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it could happen that the response body can't be decoded and the
return error is a different type from *ResponseError. This causes downstream
usage to handle different types of errors.
The solution is to always return *ResponseError and make the decoding error as
part of the *ResponseError.