HTTP stub helpers

[pengwynn]

Inspired by Octokit.rb's stub helpers, this is a work-in-progress proof-of-concept for removing some noise from our tests. We can have our 🍰 and eat it, too, because you can always do the more verbose approach if you need to.

Before we get too far, I wanted to see what @jingweno thinks of the approach.

/cc @obsc @dhruvsinghal @dhs252

[owenthereal]

@pengwynn 👍 Good refactoring! So much DRYer.

[owenthereal]

Could prob. pass a func at the last for assertion or optional manipulation as well:

func stubGet(t *testing.T, path, fixture string, params map[string]string, f func(w http.ResponseWriter, r *http.Request)) {
}


func stubRequest(t *testing.T, method string, path string, fixture string, params map[string]string, f func(w http.ResponseWriter, r *http.Request)) {
  ...

  mux.HandleFunc(path, func(w http.ResponseWriter, r *http.Request) {
       if f != nil {
          f(w, r)
       } 
  }
}

[pengwynn]

Oh good call. I like that idea.

[obsc]

I really like that idea as well.

Looking through the code again, there's only a single place where we respond with a fixture and we need other assertions (users_test.go). Other locations with asserts (gists_test.go) respond with an arbitrary string (in this case "hello").
It might be a better idea to pass in the full response rather than just the fixture name.