Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking change: docs [ * ], Organization [Remove 422 HTTP error response], Project Card [Removes 422 error response] #35

Merged
merged 2 commits into from Feb 1, 2024

Conversation

octokitbot
Copy link
Collaborator

"The latest OpenAPI spec resulted in changes to the generated code. Please review, set an applicable commit message, merge, and tag a release as appropriate."

Copy link

what-the-diff bot commented Jan 31, 2024

PR Summary

  • Modification in kiota-lock.json

    • This change involves updates to a file named kiota-lock.json in the package for GitHub. These are typically used for 'locking' certain project aspects, such as version numbers and descriptions, to a specific state. The key updates are:
      • The descriptionHash, a unique identifier for the description, was updated.
      • The kiotaVersion, which contains information about the version of the Kiota (a tool we use to generate code), was also updated.
  • Removal of OrganizationFull422Error structure in with_org_item_request_builder.go

    • This is a change to a file called with_org_item_request_builder.go which is part of the GitHub package specifically dealing with organizations. The OrganizationFull422Error structure and the methods related to it were removed. This structure was previously used to handle a specific type of error message when an organization was full, but is no longer required.
  • Removal of ProjectCard422Error structure in columns_item_cards_request_builder.go

    • This change is in a file named columns_item_cards_request_builder.go that resides in a GitHub projects package. It involves the removal of the ProjectCard422Error structure and related methods. This structure was once needed to tackle a specific error relating to project cards but is not necessary anymore.

These changes seem to be focused on updating core components and simplifying the codebase, removing redundant error handling structures. This should make the code easier to maintain and less prone to errors in the future.

@nickfloyd nickfloyd changed the title Changes in generated code breaking change: docs [ * ], Organization [Remove 422 HTTP error response], Project Card [Removes 422 error response] Feb 1, 2024
@nickfloyd nickfloyd added Type: Breaking change Used to note any change that requires a major version bump Type: Generated For Generated Code PRs labels Feb 1, 2024
@nickfloyd
Copy link
Collaborator

Note: Alpha breaking change does not increment major version.

@nickfloyd nickfloyd merged commit a10d16e into main Feb 1, 2024
4 checks passed
@nickfloyd nickfloyd deleted the generated-code-update branch February 1, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Breaking change Used to note any change that requires a major version bump Type: Generated For Generated Code PRs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants