Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "cdn.pika.dev" with "cdn.skypack.dev" in README #209

Closed
5 tasks
first-timers bot opened this issue Oct 15, 2020 · 5 comments
Closed
5 tasks

Replace "cdn.pika.dev" with "cdn.skypack.dev" in README #209

first-timers bot opened this issue Oct 15, 2020 · 5 comments
Assignees
Labels
Type: Bug Something isn't working as documented Type: Documentation Improvements or additions to documentation

Comments

@first-timers
Copy link

first-timers bot commented Oct 15, 2020

πŸ†•πŸ₯☝ First Timers Only.

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you πŸ’

About First Timers Only.

πŸ€” What you will need to know.

The Pika CDN is now Skypack, see https://www.pika.dev/cdn. The CDN at https://cdn.pika.dev/ no longer works, all URLs must be replaced with the new CDN: https://cdn.skypack.dev/. We currently recommend using cdn.pika.dev to import the library into the browser, but that no longer works. Replacing it with cdn.skypack.dev will make it work again.

πŸ“‹ Step by Step

  • πŸ™‹ Claim this issue: Comment below.

    More than one person can work on this issue, don't worry if it's already claimed.

  • πŸ“ Update the file \README.md (press the little pen Icon) and edit as shown below:

@@ -29,11 +29,11 @@
 Browsers
 </th><td width=100%>
 
-Load `@octokit/graphql` directly from [cdn.pika.dev](https://cdn.pika.dev)
+Load `@octokit/graphql` directly from [cdn.skypack.dev](https://cdn.skypack.dev)
 
 ```html
 <script type="module">
-  import { endpoint } from "https://cdn.pika.dev/@octokit/graphql";
+  import { endpoint } from "https://cdn.skypack.dev/@octokit/graphql";
 </script>
 ```
 
  • πŸ’Ύ Commit your changes

  • πŸ”€ Start a Pull Request. There are two ways how you can start a pull request:

    1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
    2. You can edit files directly in your browser
  • 🏁 Done Ask for a review :)

If there are more than one pull requests with the correct change, we will merge the first one, but attribute the change to all authors who made the same change using @Co-authored-by, so yo can be sure your contribution will count.

πŸ€”β“ Questions

Leave a comment below!

This issue was created by First-Timers-Bot.

@gr2m gr2m added Type: Bug Something isn't working as documented Type: Documentation Improvements or additions to documentation labels Oct 15, 2020
@hexxdump
Copy link

is this issue open ?

@gr2m
Copy link
Contributor

gr2m commented Oct 17, 2020

All yours @hexxdump! We can accept many pull requests for this issue, so if anyone else would like to give it a try, please comment below. Enjoy!

@chxtio
Copy link

chxtio commented Nov 1, 2020

Hi, I would like to give this a try for my first PR

@gr2m
Copy link
Contributor

gr2m commented Nov 1, 2020

@chxtio of course πŸ‘πŸΌ

@gr2m gr2m linked a pull request Nov 1, 2020 that will close this issue
@gr2m gr2m closed this as completed in 7399bb6 Nov 1, 2020
@github-actions
Copy link

github-actions bot commented Nov 1, 2020

πŸŽ‰ This issue has been resolved in version 4.5.7 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants