Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove type imports from "http" for Deno compatibility #221

Merged
merged 3 commits into from
Apr 17, 2021
Merged

fix: remove type imports from "http" for Deno compatibility #221

merged 3 commits into from
Apr 17, 2021

Conversation

laughedelic
Copy link
Contributor

Fixes #218.

@ghost ghost added this to Inbox in JS Apr 16, 2021
@wolfy1339 wolfy1339 added Type: Bug Something isn't working as documented deno typescript Relevant to TypeScript users only labels Apr 16, 2021
@ghost ghost moved this from Inbox to Bugs in JS Apr 16, 2021
@gr2m @laughedelic
Update src/middleware/node/parse-request.ts
e79a011 
indeed, thanks a lot!

Co-authored-by: Alexey Alekhin <laughedelic@gmail.com>
gr2m
gr2m approved these changes Apr 17, 2021
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 💐🦕

@gr2m gr2m merged commit 6a51895 into octokit:master Apr 17, 2021
JS automation moved this from Bugs to Done Apr 17, 2021
@github-actions
Copy link

🎉 This PR is included in version 3.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@laughedelic laughedelic deleted the deno-compat/http branch April 17, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
deno Type: Bug Something isn't working as documented typescript Relevant to TypeScript users only
Projects
No open projects
JS
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot be imported by Deno
3 participants
@laughedelic @gr2m @wolfy1339