Sort method arguments. #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The args in the GitHub schema have changed order, and I've been told that relying on the order returned by the schema isn't a good idea, so improve our sorting of args: - Args with no default value come first (requirement of C# language) - Then come paging args, sorted "first", "after", "last", "before" - All other args are sorted alphabetically
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
==========================================
+ Coverage 87.95% 88.01% +0.06%
==========================================
Files 73 73
Lines 3454 3472 +18
==========================================
+ Hits 3038 3056 +18
Misses 416 416
|
StanleyGoldman
approved these changes
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change was recently made to the GitHub GraphQL schema that made the arguments to GraphQL fields change. Asking the GraphQL team they said it's best not to rely on the order of arguments returned by the schema, so this PR adds code to sort arguments: