-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Typings not resolving correctly for rest/checks/get & rest/checks/update #2564
[BUG]: Typings not resolving correctly for rest/checks/get & rest/checks/update #2564
Comments
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with |
I just double checked the generated endpoints and types, and the URL parameters are set as required, the body parameters are all defined as you would expect. Are you able to use Octokit directly instead of using |
Thanks for confirming that. I can't seem to reproduce this myself. In the Typescript transpilation of the OpenAPI spec everything seems fine. Are you able to diagnose this? |
The base types from You can see in my TypeScript playground the issue here. The types for this endpoint in I have narrowed it down to the @gr2m Do you recall why the |
I don't, sorry 😞 |
At that point there where the |
feel free to experiment and remove it, I was learning TypeScript as I was building this, it's likely that I messed things up. The types I built for https://github.com/octokit/octokit-next.js are more elegant 🤷 I really wish we could complete that work |
I removed the I believe that that would alleviate this issue. I will prepare a PR to fix that |
It seems we have run into this issue before: octokit/plugin-rest-endpoint-methods.js#441 |
What happened?
I noticed this when trying to use
octokit.rest.checks.update
:I inspected the params further, comparing with
create
, usingstatus
as an example:Appears to be related to the type generation for
/repos/{owner}/{repo}/check-runs/{check_run_id}
The documentation indicates that
status
should be available, but trying to get any types for this endpoint results in unknown:Versions
Node 20.8.1
Relevant log output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: