Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still not strong named at nuget.org ? #2382

Closed
wangyoutian opened this issue Dec 13, 2021 · 2 comments
Closed

Still not strong named at nuget.org ? #2382

wangyoutian opened this issue Dec 13, 2021 · 2 comments
Labels
Type: Feature New feature or request

Comments

@wangyoutian
Copy link

wangyoutian commented Dec 13, 2021

After I installed octokit from nuget.org, I exported the meta of the installed dll and found it's still not strong-named. The dumped meta is :

"Octokit, Version=0.50.0.0, Culture=neutral, PublicKeyToken=null"

Being unstrong-named, it brings about some issue in my project, which is strong named.

I saw at this repo that whether to strong-name has been discussed and the decision to strong-name is made. So where can I found the strong-name version?

I pulled this repo to my local computer. I found the source code is not strong named. I tried to strong-name it locally; it is done. But I think I would prefer the official strong name version to avoid some issues such as mismatched ".snk" file.

Any advice?

Thanks.

@nickfloyd
Copy link
Contributor

nickfloyd commented Apr 25, 2022

Possible duplicate of: #1604

@JonruAlveus
Copy link
Collaborator

We are now strong signed 👍

@nickfloyd nickfloyd added Type: Feature New feature or request and removed improvement labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants