This repository has been archived by the owner on Dec 4, 2018. It is now read-only.
Moondragon #240
Merged
Moondragon #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| NSString *previewContentType = [NSString stringWithFormat:@"application/vnd.github.%@+json", OCTClientPreviewAPIVersion]; | ||
| NSString *baseContentType = @"application/vnd.github.%@+json"; | ||
| NSString *stableContentType = [NSString stringWithFormat:baseContentType, OCTClientAPIVersion]; | ||
| NSString *previewContentType = [NSString stringWithFormat:baseContentType, OCTClientPreviewAPIVersion]; |
There was a problem hiding this comment.
Do we still need this?
There was a problem hiding this comment.
Doesn't look like it.
There was a problem hiding this comment.
We do, apparently still in preview.
| @@ -16,7 +16,7 @@ | |||
| @implementation OCTClient (Organizations) | |||
|
|
|||
| - (RACSignal *)fetchUserOrganizations { | |||
| return [[self enqueueUserRequestWithMethod:@"GET" relativePath:@"/orgs" parameters:nil resultClass:OCTOrganization.class] oct_parsedResults]; | |||
| return [[self enqueueUserRequestWithMethod:@"GET" relativePath:@"/user/orgs" parameters:nil resultClass:OCTOrganization.class] oct_parsedResults]; | |||
There was a problem hiding this comment.
I'm getting 404s, because “user requests” already have this prefix.
|
🎱 |
| @@ -44,8 +44,13 @@ | |||
| NSString * const OCTClientErrorMessagesKey = @"OCTClientErrorMessagesKey"; | |||
|
|
|||
| NSString * const OCTClientAPIVersion = @"v3"; | |||
|
|
|||
| /// See https://developer.github.com/changes/2014-12-08-removing-authorizations-token/ | |||
| NSString * const OCTClientPreviewAPIVersion = @"mirage-preview"; | |||
There was a problem hiding this comment.
Can you rename this to clarify which preview API it's talking about?
|
9️⃣ |
|
0️⃣ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API changes in light of https://developer.github.com/changes/2014-12-08-organization-permissions-api-preview/