Merge pull request #1067 from octokit/hard-coded-pengwynn

Remove hard-coded references to pengwynn in org specs

spec/cassettes/Octokit_Client_Organizations/_add_team_membership/invites_a_user_to_a_team.json

@@ -1 +1 @@
-{"http_interactions":[{"request":{"method":"put","uri":"https://api.github.com/teams/<GITHUB_TEAM_ID>/memberships/<GITHUB_LOGIN>","body":{"encoding":"UTF-8","base64_string":"e30=\n"},"headers":{"Accept":["application/vnd.github.v3+json"],"User-Agent":["Octokit Ruby Gem 4.11.0"],"Content-Type":["application/json"],"Authorization":["token <<ACCESS_TOKEN>>"],"Accept-Encoding":["gzip;q=1.0,deflate;q=0.6,identity;q=0.3"]}},"response":{"status":{"code":200,"message":"OK"},"headers":{"Server":["GitHub.com"],"Date":["Fri, 07 Sep 2018 03:49:41 GMT"],"Content-Type":["application/json; charset=utf-8"],"Transfer-Encoding":["chunked"],"Status":["200 OK"],"X-Ratelimit-Limit":["5000"],"X-Ratelimit-Remaining":["4777"],"X-Ratelimit-Reset":["1536294917"],"Cache-Control":["private, max-age=60, s-maxage=60"],"Vary":["Accept, Authorization, Cookie, X-GitHub-OTP"],"Etag":["W/\"cb7a3f06c01d6b1c54e55e4832483558\""],"X-Oauth-Scopes":["admin:gpg_key, admin:org, admin:org_hook, admin:public_key, admin:repo_hook, delete_repo, gist, notifications, repo, user, write:discussion"],"X-Accepted-Oauth-Scopes":["admin:org, repo"],"X-Github-Media-Type":["github.v3; format=json"],"Access-Control-Expose-Headers":["ETag, Link, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval"],"Access-Control-Allow-Origin":["*"],"Strict-Transport-Security":["max-age=31536000; includeSubdomains; preload"],"X-Frame-Options":["deny"],"X-Content-Type-Options":["nosniff"],"X-Xss-Protection":["1; mode=block"],"Referrer-Policy":["origin-when-cross-origin, strict-origin-when-cross-origin"],"Content-Security-Policy":["default-src 'none'"],"X-Runtime-Rack":["0.039<GITHUB_TEST_INTEGRATION_INSTALLATION>9"],"X-Github-Request-Id":["F6FA:1167:354F8FD:70218B1:5B91F554"]},"body":{"encoding":"ASCII-8BIT","base64_string":"eyJzdGF0ZSI6ImFjdGl2ZSIsInJvbGUiOiJtYWludGFpbmVyIiwidXJsIjoi\naHR0cHM6Ly9hcGkuZ2l0aHViLmNvbS90ZWFtcy88R0lUSFVCX1RFQU1fSUQ+\nL21lbWJlcnNoaXBzLzxHSVRIVUJfTE9HSU4+In0=\n"},"http_version":null},"recorded_at":"Fri, 07 Sep 2018 03:49:41 GMT"}],"recorded_with":"VCR 3.0.3"}
+{"http_interactions":[{"request":{"method":"put","uri":"https://api.github.com/teams/<GITHUB_TEAM_ID>/memberships/<GITHUB_LOGIN>","body":{"encoding":"UTF-8","base64_string":"e30=\n"},"headers":{"Accept":["application/vnd.github.v3+json"],"User-Agent":["Octokit Ruby Gem 4.11.0"],"Content-Type":["application/json"],"Authorization":["token <<ACCESS_TOKEN>>"],"Accept-Encoding":["gzip;q=1.0,deflate;q=0.6,identity;q=0.3"]}},"response":{"status":{"code":200,"message":"OK"},"headers":{"Server":["GitHub.com"],"Date":["Mon, 10 Sep 2018 20:05:29 GMT"],"Content-Type":["application/json; charset=utf-8"],"Transfer-Encoding":["chunked"],"Status":["200 OK"],"X-Ratelimit-Limit":["5000"],"X-Ratelimit-Remaining":["4998"],"X-Ratelimit-Reset":["1536613529"],"Cache-Control":["private, max-age=60, s-maxage=60"],"Vary":["Accept, Authorization, Cookie, X-GitHub-OTP"],"Etag":["W/\"cb7a3f06c01d6b1c54e55e4832483558\""],"X-Oauth-Scopes":["admin:gpg_key, admin:org, admin:org_hook, admin:public_key, admin:repo_hook, delete_repo, gist, notifications, repo, user, write:discussion"],"X-Accepted-Oauth-Scopes":["admin:org, repo"],"X-Github-Media-Type":["github.v3; format=json"],"Access-Control-Expose-Headers":["ETag, Link, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval"],"Access-Control-Allow-Origin":["*"],"Strict-Transport-Security":["max-age=31536000; includeSubdomains; preload"],"X-Frame-Options":["deny"],"X-Content-Type-Options":["nosniff"],"X-Xss-Protection":["1; mode=block"],"Referrer-Policy":["origin-when-cross-origin, strict-origin-when-cross-origin"],"Content-Security-Policy":["default-src 'none'"],"X-Runtime-Rack":["0.058766"],"X-Github-Request-Id":["EF4B:6630:1B188B:3D0C7F:5B96CE89"]},"body":{"encoding":"ASCII-8BIT","base64_string":"eyJzdGF0ZSI6ImFjdGl2ZSIsInJvbGUiOiJtYWludGFpbmVyIiwidXJsIjoi\naHR0cHM6Ly9hcGkuZ2l0aHViLmNvbS90ZWFtcy88R0lUSFVCX1RFQU1fSUQ+\nL21lbWJlcnNoaXBzLzxHSVRIVUJfTE9HSU4+In0=\n"},"http_version":null},"recorded_at":"Mon, 10 Sep 2018 20:05:29 GMT"}],"recorded_with":"VCR 3.0.3"}

spec/cassettes/Octokit_Client_Organizations/_remove_team_membership/removes_a_user_s_membership_for_a_team.json

@@ -1 +1 @@
-{"http_interactions":[{"request":{"method":"delete","uri":"https://api.github.com/teams/946194/memberships/<GITHUB_LOGIN>","body":{"encoding":"UTF-8","base64_string":"e30=\n"},"headers":{"Accept":["application/vnd.github.the-wasp-preview+json"],"User-Agent":["Octokit Ruby Gem 3.2.0"],"Authorization":["token <<ACCESS_TOKEN>>"],"Accept-Encoding":["gzip;q=1.0,deflate;q=0.6,identity;q=0.3"]}},"response":{"status":{"code":204,"message":"No Content"},"headers":{"Server":["GitHub.com"],"Date":["Mon, 04 Aug 2014 17:48:55 GMT"],"Status":["204 No Content"],"X-Ratelimit-Limit":["5000"],"X-Ratelimit-Remaining":["4996"],"X-Ratelimit-Reset":["1407177624"],"X-Oauth-Scopes":["admin:org, admin:public_key, admin:repo_hook, delete_repo, gist, notifications, repo, user"],"X-Accepted-Oauth-Scopes":["admin:org, repo"],"X-Github-Media-Type":["github.the-wasp-preview; format=json"],"X-Xss-Protection":["1; mode=block"],"X-Frame-Options":["deny"],"Content-Security-Policy":["default-src 'none'"],"Access-Control-Allow-Credentials":["true"],"Access-Control-Expose-Headers":["ETag, Link, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval"],"Access-Control-Allow-Origin":["*"],"X-Github-Request-Id":["4AC49B86:0443:7DDBA35:53DFC787"],"Strict-Transport-Security":["max-age=31536000; includeSubdomains"],"X-Content-Type-Options":["nosniff"],"Vary":["Accept-Encoding"],"X-Served-By":["c436b2b44345c72ff906059f604991e7"]},"body":{"encoding":"UTF-8","base64_string":""},"http_version":null},"recorded_at":"Mon, 04 Aug 2014 17:48:55 GMT"}],"recorded_with":"VCR 2.9.2"}
+{"http_interactions":[{"request":{"method":"delete","uri":"https://api.github.com/teams/<GITHUB_TEAM_ID>/memberships/<GITHUB_LOGIN>","body":{"encoding":"UTF-8","base64_string":"e30=\n"},"headers":{"Accept":["application/vnd.github.v3+json"],"User-Agent":["Octokit Ruby Gem 4.11.0"],"Content-Type":["application/json"],"Authorization":["token <<ACCESS_TOKEN>>"],"Accept-Encoding":["gzip;q=1.0,deflate;q=0.6,identity;q=0.3"]}},"response":{"status":{"code":204,"message":"No Content"},"headers":{"Server":["GitHub.com"],"Date":["Mon, 10 Sep 2018 20:05:30 GMT"],"Content-Type":["application/octet-stream"],"Status":["204 No Content"],"X-Ratelimit-Limit":["5000"],"X-Ratelimit-Remaining":["4997"],"X-Ratelimit-Reset":["1536613529"],"X-Oauth-Scopes":["admin:gpg_key, admin:org, admin:org_hook, admin:public_key, admin:repo_hook, delete_repo, gist, notifications, repo, user, write:discussion"],"X-Accepted-Oauth-Scopes":["admin:org, repo"],"X-Github-Media-Type":["github.v3; format=json"],"Access-Control-Expose-Headers":["ETag, Link, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval"],"Access-Control-Allow-Origin":["*"],"Strict-Transport-Security":["max-age=31536000; includeSubdomains; preload"],"X-Frame-Options":["deny"],"X-Content-Type-Options":["nosniff"],"X-Xss-Protection":["1; mode=block"],"Referrer-Policy":["origin-when-cross-origin, strict-origin-when-cross-origin"],"Content-Security-Policy":["default-src 'none'"],"X-Runtime-Rack":["0.071490"],"X-Github-Request-Id":["EF4C:662E:14FAD6:3260D3:5B96CE89"]},"body":{"encoding":"UTF-8","base64_string":""},"http_version":null},"recorded_at":"Mon, 10 Sep 2018 20:05:30 GMT"}],"recorded_with":"VCR 3.0.3"}

spec/cassettes/Octokit_Client_Organizations/_team_membership/gets_a_user_s_team_membership.json

@@ -1 +1 @@
-{"http_interactions":[{"request":{"method":"get","uri":"https://api.github.com/teams/946194/memberships/pengwynn","body":{"encoding":"US-ASCII","base64_string":""},"headers":{"Accept":["application/vnd.github.the-wasp-preview+json"],"User-Agent":["Octokit Ruby Gem 3.2.0"],"Authorization":["token <<ACCESS_TOKEN>>"],"Accept-Encoding":["gzip;q=1.0,deflate;q=0.6,identity;q=0.3"]}},"response":{"status":{"code":200,"message":"OK"},"headers":{"Server":["GitHub.com"],"Date":["Mon, 04 Aug 2014 17:40:24 GMT"],"Content-Type":["application/json; charset=utf-8"],"Transfer-Encoding":["chunked"],"Status":["200 OK"],"X-Ratelimit-Limit":["5000"],"X-Ratelimit-Remaining":["4999"],"X-Ratelimit-Reset":["1407177624"],"Cache-Control":["private, max-age=60, s-maxage=60"],"Etag":["\"1e5bb6f8104265e40ecbbe9cb006a0a7\""],"X-Oauth-Scopes":["admin:org, admin:public_key, admin:repo_hook, delete_repo, gist, notifications, repo, user"],"X-Accepted-Oauth-Scopes":["admin:org, repo"],"Vary":["Accept, Authorization, Cookie, X-GitHub-OTP","Accept-Encoding"],"X-Github-Media-Type":["github.the-wasp-preview; format=json"],"X-Xss-Protection":["1; mode=block"],"X-Frame-Options":["deny"],"Content-Security-Policy":["default-src 'none'"],"Access-Control-Allow-Credentials":["true"],"Access-Control-Expose-Headers":["ETag, Link, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval"],"Access-Control-Allow-Origin":["*"],"X-Github-Request-Id":["4AC49B86:2B9A:7E986DB:53DFC588"],"Strict-Transport-Security":["max-age=31536000; includeSubdomains"],"X-Content-Type-Options":["nosniff"],"X-Served-By":["c436b2b44345c72ff906059f604991e7"]},"body":{"encoding":"UTF-8","base64_string":"eyJzdGF0dXMiOiJhY3RpdmUiLCJ1cmwiOiJodHRwczovL2FwaS5naXRodWIu\nY29tL3RlYW1zLzk0NjE5NC9tZW1iZXJzaGlwcy9wZW5nd3lubiJ9\n"},"http_version":null},"recorded_at":"Mon, 04 Aug 2014 17:40:24 GMT"}],"recorded_with":"VCR 2.9.2"}
+{"http_interactions":[{"request":{"method":"get","uri":"https://api.github.com/teams/<GITHUB_TEAM_ID>/memberships/<GITHUB_LOGIN>","body":{"encoding":"US-ASCII","base64_string":""},"headers":{"Accept":["application/vnd.github.v3+json"],"User-Agent":["Octokit Ruby Gem 4.11.0"],"Content-Type":["application/json"],"Authorization":["token <<ACCESS_TOKEN>>"],"Accept-Encoding":["gzip;q=1.0,deflate;q=0.6,identity;q=0.3"]}},"response":{"status":{"code":200,"message":"OK"},"headers":{"Server":["GitHub.com"],"Date":["Mon, 10 Sep 2018 20:05:29 GMT"],"Content-Type":["application/json; charset=utf-8"],"Transfer-Encoding":["chunked"],"Status":["200 OK"],"X-Ratelimit-Limit":["5000"],"X-Ratelimit-Remaining":["4999"],"X-Ratelimit-Reset":["1536613529"],"Cache-Control":["private, max-age=60, s-maxage=60"],"Vary":["Accept, Authorization, Cookie, X-GitHub-OTP"],"Etag":["W/\"cb7a3f06c01d6b1c54e55e4832483558\""],"X-Oauth-Scopes":["admin:gpg_key, admin:org, admin:org_hook, admin:public_key, admin:repo_hook, delete_repo, gist, notifications, repo, user, write:discussion"],"X-Accepted-Oauth-Scopes":["admin:org, read:org, repo, write:org"],"X-Github-Media-Type":["github.v3; format=json"],"Access-Control-Expose-Headers":["ETag, Link, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval"],"Access-Control-Allow-Origin":["*"],"Strict-Transport-Security":["max-age=31536000; includeSubdomains; preload"],"X-Frame-Options":["deny"],"X-Content-Type-Options":["nosniff"],"X-Xss-Protection":["1; mode=block"],"Referrer-Policy":["origin-when-cross-origin, strict-origin-when-cross-origin"],"Content-Security-Policy":["default-src 'none'"],"X-Runtime-Rack":["0.035836"],"X-Github-Request-Id":["EF4A:662E:14FA92:32603B:5B96CE88"]},"body":{"encoding":"ASCII-8BIT","base64_string":"eyJzdGF0ZSI6ImFjdGl2ZSIsInJvbGUiOiJtYWludGFpbmVyIiwidXJsIjoi\naHR0cHM6Ly9hcGkuZ2l0aHViLmNvbS90ZWFtcy88R0lUSFVCX1RFQU1fSUQ+\nL21lbWJlcnNoaXBzLzxHSVRIVUJfTE9HSU4+In0=\n"},"http_version":null},"recorded_at":"Mon, 10 Sep 2018 20:05:29 GMT"}],"recorded_with":"VCR 3.0.3"}

spec/octokit/client/organizations_spec.rb

@@ -268,14 +268,6 @@
     end
   end # .user_teams
 
-  describe ".team_membership", :vcr do
-    it "gets a user's team membership" do
-      membership = @client.team_membership(946194, "pengwynn")
-      assert_requested :get, github_url("teams/946194/memberships/pengwynn")
-      expect(membership.status).to eq("active")
-    end
-  end # .team_membership
-
   describe ".add_team_membership", :vcr do
     it "invites a user to a team" do
       membership = @client.add_team_membership(test_github_team_id, test_github_login)
@@ -284,10 +276,18 @@
     end
   end # .add_team_membership
 
+  describe ".team_membership", :vcr do
+    it "gets a user's team membership" do
+      membership = @client.team_membership(test_github_team_id, test_github_login)
+      assert_requested :get, github_url("teams/#{test_github_team_id}/memberships/#{test_github_login}")
+      expect(membership.state).to eq("active")
+    end
+  end # .team_membership
+
   describe ".remove_team_membership", :vcr do
     it "removes a user's membership for a team" do
-      result = @client.remove_team_membership(946194, test_github_login)
-      assert_requested :delete, github_url("teams/946194/memberships/#{test_github_login}")
+      result = @client.remove_team_membership(test_github_team_id, test_github_login)
+      assert_requested :delete, github_url("teams/#{test_github_team_id}/memberships/#{test_github_login}")
       expect(result).to be true
     end
   end # .remove_team_membership