Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Octokit::Client::Authorizations, which targets the now-gone OAuth Authorizations API #1429

Closed
timrogers opened this issue Jun 7, 2022 · 0 comments 路 Fixed by #1494
Closed

Remove Octokit::Client::Authorizations, which targets the now-gone OAuth Authorizations API #1429

timrogers opened this issue Jun 7, 2022 · 0 comments 路 Fixed by #1494
Assignees
@kfcampbell
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Comments

@timrogers
Copy link
Contributor

We can remove this module because the APIs it exposes were deprecated back in 2020. I can see in GitHub's logs that these APIs are indeed not being hit anymore 馃槄

This should be done in a breaking version since it removes code that people could be depending on - even if technically it hasn't been working for the past 18 months anyway.
@kfcampbell kfcampbell mentioned this issue Oct 17, 2022
Merged
@kfcampbell kfcampbell self-assigned this Oct 17, 2022
@nickfloyd nickfloyd added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR Status: Up for grabs Issues that are ready to be worked on by anyone and removed housekeeping labels Oct 28, 2022
@danbernier danbernier mentioned this issue Oct 19, 2023
Closed
1 task
f1sherman added a commit to f1sherman/gitx that referenced this issue Feb 6, 2024
@f1sherman
Remove obsolete Github OAuth Authorization
c5c9e99 
The Github OAuth Authorization API [was deprecated back in
2020](https://developer.github.com/changes/2020-02-14-deprecating-oauth-auth-endpoint/)
and [removed from Octokit in
2022](octokit/octokit.rb#1429).

This change updates the library to ask for the personal access token
directly.
@f1sherman f1sherman mentioned this issue Feb 6, 2024
Merged
f1sherman added a commit to f1sherman/gitx that referenced this issue Feb 6, 2024
@f1sherman
Remove obsolete Github OAuth Authorization
40b78c1 
The Github OAuth Authorization API [was deprecated back in
2020](https://developer.github.com/changes/2020-02-14-deprecating-oauth-auth-endpoint/)
and [removed from Octokit in
2022](octokit/octokit.rb#1429).

This change updates the library to ask for the personal access token
directly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kfcampbell kfcampbell

Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Octokit::Client::Authorizations octokit/octokit.rb
4 participants
@timrogers @nickfloyd @kfcampbell and others