Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable issue events API to return project events #1183

Merged
merged 3 commits into from Feb 28, 2020

Conversation

gammons
Copy link

@gammons gammons commented Jan 19, 2020

Hi there,

This change allows the issue_events api to return project card events, by using the application/vnd.github.starfox-preview+json header.

This change works, but it's currently lacking specs. I'm thinking the best way to exercise these specs is if one of the admins of this repo could create a project board and put a couple of issues on it. I can then record the api response and write specs that exercise the response from there.

But, I'm open to any ideas on how to move forward with specs!

@gammons gammons requested a review from tarebyte January 19, 2020 12:56
@indigok
Copy link

indigok commented Feb 28, 2020

Hi @gammons 👋

Specs are created off of test repos as set by environment variables. For this change though, we don't need to rerecord them as the response hasn't really changed, it just allows more events. I've gone ahead and added the preview to the test and so it should be good to merge when the tests pass ✨

@tarebyte tarebyte merged commit b90cd77 into octokit:4-stable Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants