-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: paginatingEndpoints
and isPaginatingEndpoint
#283
Conversation
90a044a
to
f51ab08
Compare
f51ab08
to
4454928
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add tests for the new exports to https://github.com/octokit/plugin-paginate-rest.js/blob/master/test/smoke.test.ts?
As this adds features, we should update the docs.
Can you add the new exports to the imports in https://github.com/octokit/plugin-paginate-rest.js/tree/42df25d3ccfcdb27194032d6a77d2495af085a6a#usage and add sections for each export to the doc?
Tests are already in test/paginating-endpoints.test.ts. Anything specific that should be additionally tested in smoke.test.ts?
Sure. |
I just like to test all exports of a module in the smoke test. Only import the function and the array and check that they are a function/array respectively. It's just an additional safety measure to avoid accidental breaking changes |
Ok, added the smoke test. All the changes to README are already provided in #284. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
🎉 This PR is included in version 2.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
The
isPaginatingEndpoint
function provides a runtime type-guard forkeyof PaginatingEndpoint
. The PR also exposespaginatingEndpoints
array that lists all the keys in the generatedPaginatingEndpoints
interface.