Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: paginatingEndpoints and isPaginatingEndpoint #283

Merged
merged 3 commits into from
Mar 10, 2021

Conversation

ptomulik
Copy link
Contributor

The isPaginatingEndpoint function provides a runtime type-guard for keyof PaginatingEndpoint. The PR also exposes paginatingEndpoints array that lists all the keys in the generated PaginatingEndpoints interface.

@ghost ghost added this to Inbox in JS Mar 10, 2021
@gr2m gr2m added feature typescript Relevant to TypeScript users only labels Mar 10, 2021
@ghost ghost moved this from Inbox to Features in JS Mar 10, 2021
@gr2m gr2m removed the typescript Relevant to TypeScript users only label Mar 10, 2021
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests for the new exports to https://github.com/octokit/plugin-paginate-rest.js/blob/master/test/smoke.test.ts?

As this adds features, we should update the docs.

Can you add the new exports to the imports in https://github.com/octokit/plugin-paginate-rest.js/tree/42df25d3ccfcdb27194032d6a77d2495af085a6a#usage and add sections for each export to the doc?

@ptomulik
Copy link
Contributor Author

Can you add tests for the new exports to https://github.com/octokit/plugin-paginate-rest.js/blob/master/test/smoke.test.ts?

Tests are already in test/paginating-endpoints.test.ts. Anything specific that should be additionally tested in smoke.test.ts?

As this adds features, we should update the docs.

Can you add the new exports to the imports in https://github.com/octokit/plugin-paginate-rest.js/tree/42df25d3ccfcdb27194032d6a77d2495af085a6a#usage and add sections for each export to the doc?

Sure.

@gr2m
Copy link
Contributor

gr2m commented Mar 10, 2021

Anything specific that should be additionally tested in smoke.test.ts?

I just like to test all exports of a module in the smoke test. Only import the function and the array and check that they are a function/array respectively. It's just an additional safety measure to avoid accidental breaking changes

@ptomulik
Copy link
Contributor Author

Ok, added the smoke test. All the changes to README are already provided in #284.

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gr2m gr2m merged commit 0db1a8a into octokit:master Mar 10, 2021
JS automation moved this from Features to Done Mar 10, 2021
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
JS
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants