Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapFunction<*,{R|MR}> => MapFunction<*,M> #291

Merged
merged 2 commits into from
Mar 31, 2021
Merged

Conversation

ptomulik
Copy link
Contributor

A cosmetic change - use consistently M as MapFunction's second parameter's name.

@ghost ghost added this to Inbox in JS Mar 26, 2021
@gr2m gr2m added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR typescript Relevant to TypeScript users only labels Mar 31, 2021
@ghost ghost moved this from Inbox to Maintenance in JS Mar 31, 2021
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

I hate these abbreviations, I don't know why they became so popular with TypeScript folks. I try to avoid them and use full tames such as TResponseData etc, but this is some older code and I just followed the lead from the TypeScript docs

@gr2m gr2m merged commit 597472c into octokit:master Mar 31, 2021
JS automation moved this from Maintenance to Done Mar 31, 2021
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.13.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ptomulik ptomulik deleted the r2m branch June 14, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR typescript Relevant to TypeScript users only
Projects
No open projects
JS
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants