Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "cdn.pika.dev" with "cdn.skypack.dev" in README #245

Closed
5 tasks
first-timers bot opened this issue Oct 15, 2020 · 14 comments
Closed
5 tasks

Replace "cdn.pika.dev" with "cdn.skypack.dev" in README #245

first-timers bot opened this issue Oct 15, 2020 · 14 comments
Labels
Type: Bug Something isn't working as documented Type: Documentation Improvements or additions to documentation
Projects

Comments

@first-timers
Copy link

first-timers bot commented Oct 15, 2020

πŸ†•πŸ₯☝ First Timers Only.

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you πŸ’

About First Timers Only.

πŸ€” What you will need to know.

The Pika CDN is now Skypack, see https://www.pika.dev/cdn. The CDN at https://cdn.pika.dev/ no longer works, all URLs must be replaced with the new CDN: https://cdn.skypack.dev/. We currently recommend using cdn.pika.dev to import the library into the browser, but that no longer works. Replacing it with cdn.skypack.dev will make it work again.

πŸ“‹ Step by Step

  • πŸ™‹ Claim this issue: Comment below.

    More than one person can work on this issue, don't worry if it's already claimed.

  • πŸ“ Update the file \README.md (press the little pen Icon) and edit as shown below:

@@ -13,12 +13,12 @@
 Browsers
 </th><td width=100%>
 
-Load `@octokit/plugin-rest-endpoint-methods` and [`@octokit/core`](https://github.com/octokit/core.js) (or core-compatible module) directly from [cdn.pika.dev](https://cdn.pika.dev)
+Load `@octokit/plugin-rest-endpoint-methods` and [`@octokit/core`](https://github.com/octokit/core.js) (or core-compatible module) directly from [cdn.skypack.dev](https://cdn.skypack.dev)
 
 ```html
 <script type="module">
-  import { Octokit } from "https://cdn.pika.dev/@octokit/core";
-  import { restEndpointMethods } from "https://cdn.pika.dev/@octokit/plugin-rest-endpoint-methods";
+  import { Octokit } from "https://cdn.skypack.dev/@octokit/core";
+  import { restEndpointMethods } from "https://cdn.skypack.dev/@octokit/plugin-rest-endpoint-methods";
 </script>
 ```
 
  • πŸ’Ύ Commit your changes

  • πŸ”€ Start a Pull Request. There are two ways how you can start a pull request:

    1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
    2. You can edit files directly in your browser
  • 🏁 Done Ask for a review :)

If there are more than one pull requests with the correct change, we will merge the first one, but attribute the change to all authors who made the same change using @Co-authored-by, so yo can be sure your contribution will count.

πŸ€”β“ Questions

Leave a comment below!

This issue was created by First-Timers-Bot.

@ghost ghost added this to Inbox in JS Oct 15, 2020
@gr2m gr2m added Type: Bug Something isn't working as documented Type: Documentation Improvements or additions to documentation labels Oct 15, 2020
@ghost ghost moved this from Inbox to Bugs in JS Oct 15, 2020
@dionysus
Copy link

Hi! I can try this out!

@dionysus
Copy link

I submited a PR! It does say to add a label (which I can't seem to do). Please let me know!

@nk183
Copy link

nk183 commented Oct 16, 2020

@gr2m Can I work on this issue?

@Dvd1234
Copy link

Dvd1234 commented Oct 18, 2020

Hey. Can I try this out?

@gr2m gr2m unassigned dionysus and nk183 Oct 18, 2020
@gr2m
Copy link
Contributor

gr2m commented Oct 18, 2020

@dionysus @Dvd1234 absolutely πŸ‘πŸΌ

@nk183 see my comment at #247 (comment), you already submitted a pull request to a first-timer-only project, so if you don't mind, we'd leave this issue to others who didn't yet?

@gr2m gr2m linked a pull request Oct 18, 2020 that will close this issue
@beneclauss
Copy link

I would like to try this one!

@jhalak27
Copy link

Hey, I am new here. Can I work on this?

@gr2m gr2m assigned dionysus, jhalak27, nk183 and beneclauss and unassigned dionysus and Dvd1234 Oct 19, 2020
@gr2m
Copy link
Contributor

gr2m commented Oct 19, 2020

@beneclauss @jhalak27 enjoy πŸ‘πŸΌ

@jhalak27
Copy link

@gr2m I have submitted a PR for this. Not sure how to add a label to it. Could have a look at it?

@gr2m gr2m linked a pull request Oct 19, 2020 that will close this issue
@nk183 nk183 removed their assignment Oct 20, 2020
@mingweisoo
Copy link

hi I'd like to work on this issue!

@gr2m
Copy link
Contributor

gr2m commented Oct 25, 2020

@evansusu you got it. But can you please close your other PRs? These issues are for first-time contributors only. If you'd like to contribute after that, we have some help wanted issues that you could look into?

@mingweisoo
Copy link

@gr2m Hi thanks! Sorry I just started too so am quite new to this! What should my next step be?

@gr2m
Copy link
Contributor

gr2m commented Oct 25, 2020

no problem at all! Welcome to Open Source :)

I left a review on your pull request at #257, we can discuss there if you have further questions

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2020

πŸŽ‰ This issue has been resolved in version 4.2.1 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment