Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated with Skypack links #249

Closed
wants to merge 1 commit into from
Closed

Updated with Skypack links #249

wants to merge 1 commit into from

Conversation

Dvd1234
Copy link

@Dvd1234 Dvd1234 commented Oct 19, 2020

Hey @gr2m . Thanks for the opportunity. :) Pika CDN no longer works and has been replaced by Skypack CDN. Please merge the PR. Thansk

Pika CDN no longer works and has been replaced by Skypack CDN.
@ghost ghost added this to Inbox in JS Oct 19, 2020
@wolfy1339 wolfy1339 added Type: Bug Something isn't working as documented Type: Documentation Improvements or additions to documentation hacktoberfest-accepted labels Oct 19, 2020
@ghost ghost moved this from Inbox to Bugs in JS Oct 19, 2020
@gr2m gr2m linked an issue Oct 19, 2020 that may be closed by this pull request
5 tasks
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, yay! We will merge your changes shortly, together with other pull requests that address the same issue. We also added the hacktoberfest-accepted label so your pull request counts already, in case you are participating.

@gr2m gr2m closed this in 67a81ff Nov 1, 2020
JS automation moved this from Bugs to Done Nov 1, 2020
@gr2m
Copy link
Contributor

gr2m commented Nov 1, 2020

Congratulations 🥳 We hope you enjoyed the process of sending the pull requests, and maybe learned a thing or two? If anything was unclear, or if you have any suggestions on how we can improve the suggestions in the issue #123, please let us know! It will help future first time contributors!

If you are looking to make another pull requests, look out for issues with the help wanted label. They are not as straight forward as the first-timers-only issues, but hey, you no longer are a first-timers 🙂 You can find help wanted issues here.

You can help us by starring this repository, as well as our primary repository at https://github.com/octokit/rest.js/ ⭐️ Stars help others to discover our project.

If you are interested in Octokit and future opportunities to contribute, you can subscribe to our announcement discussion at https://github.com/octokit/rest.js/discussions/620. We will post and update soon and will point out issues you can contribute to.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2020

🎉 This issue has been resolved in version 4.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented Type: Documentation Improvements or additions to documentation
Projects
No open projects
JS
  
Done
Development

Successfully merging this pull request may close these issues.

Replace "cdn.pika.dev" with "cdn.skypack.dev" in README
3 participants