Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert "feat: many unreleased updates to endpoint methods (#607)" #610

Merged
merged 1 commit into from Jan 21, 2023

Conversation

wolfy1339
Copy link
Member

This reverts commit 1e9bf68.


Behavior

Before the change?

  • Breaking changes were introduced in a feature version

After the change?

  • The breaking changes will be reverted

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@wolfy1339 wolfy1339 added Type: Bug Something isn't working as documented Priority: High labels Jan 20, 2023
@ghost ghost added this to Bugs in JS Jan 20, 2023
@wolfy1339
Copy link
Member Author

I think there's something wrong with the required tests in this repo.
There's 2 tests that no longer exist, and haven't existed for a while now marked as required.

The Test / test workflow should be the one set to be required

@wolfy1339
Copy link
Member Author

It seems to only have happened on this PR

@kfcampbell
Copy link
Member

That's bizarre. I don't see any differences in the workflows between these two branches and main. I'm not aware of any configuration options we can tweak in the Actions tab.

@wolfy1339
Copy link
Member Author

I have no idea either. You should be able to merge it anyways as an admin

@kfcampbell kfcampbell merged commit 691b726 into 6.x Jan 21, 2023
JS automation moved this from Bugs to Done Jan 21, 2023
@kfcampbell kfcampbell deleted the revert-breaking-changes branch January 21, 2023 01:02
@kfcampbell
Copy link
Member

Sure, I've done so now.

@github-actions
Copy link
Contributor

🎉 This PR is included in version 6.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @6.x Type: Bug Something isn't working as documented
Projects
Archived in project
JS
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants