Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): add example for error handling #334

Merged
merged 1 commit into from
May 26, 2023
Merged

docs(README): add example for error handling #334

merged 1 commit into from
May 26, 2023

Conversation

till
Copy link
Contributor

@till till commented May 26, 2023

As discussed: octokit/octokit.js#2039

@ghost ghost added this to Inbox in JS May 26, 2023
@nickfloyd
Copy link
Contributor

Hey @till, Thanks for this change! ❤️ . The doc looks good content-wise but has some linting issues. Could you either:

  1. Update this to reflect what I mentioned above and push the update to this PR or...
  2. Set the fork to give maintainers write access and I'd be glad to make the change for you!

@till
Copy link
Contributor Author

till commented May 26, 2023

Hey @till, Thanks for this change! ❤️ . The doc looks good content-wise but has some linting issues. Could you either:

  1. Update this to reflect what I mentioned above and push the update to this PR or...
  2. Set the fork to give maintainers write access and I'd be glad to make the change for you!

Hey @nickfloyd — allow edits from maintainers is already checked (I see it right next to this field). So feel free to change as needed. I don't see the exact issues as prettier doesn't say in the log and because I don't have a local clone. But your help is appreciated. :)

@nickfloyd
Copy link
Contributor

Hey @till, unfortunately, I don't have write access to your fork.

You don't have write access to the till/request-error.js repository, so you cannot push changes to it.
To obtain write access we will point this codespace at your fork of till/request-error.js, creating that fork if it doesn't exist.

Can you run npm run lint:fix from your fork and commit the changes?

@till
Copy link
Contributor Author

till commented May 26, 2023

I did, committed and squashed. LMK

@nickfloyd nickfloyd added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label May 26, 2023
@ghost ghost moved this from Inbox to Maintenance in JS May 26, 2023
@till
Copy link
Contributor Author

till commented May 26, 2023

Btw, any idea what this means?

image

@nickfloyd nickfloyd merged commit 7e4f2c3 into octokit:main May 26, 2023
8 checks passed
JS automation moved this from Maintenance to Done May 26, 2023
@till till deleted the patch-1 branch May 26, 2023 19:55
@nickfloyd
Copy link
Contributor

Btw, any idea what this means?

image

That is the console message that you'll get when maintainer access is not enabled on a fork.

@till
Copy link
Contributor Author

till commented May 26, 2023

@nickfloyd no, no, at the right [x] Allow edits by maintainers — it was checked all along. Was just curious. Anyway, thanks for merging.

@github-actions
Copy link

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
JS
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants