Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an Error is instantiated in nodejs, then the Error is enriched with the stacktrace anyway. I could not figure out, in which case the stacktrace could be wrong.
We significantly increase the instantiation speed.
The stacktrace generation is in general the slowest part of the error instantiation. So touching other parts of the code will not change the performance of the error instantiation significantly. E.g. we could check if the query contains a
?
before doing the.replace
calls forclient_secret
andaccess_token
which should boost the performance, but it has no effect, because of the slow instantiation of Errors in general.before:
after: