Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report documentation with error message #667

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Feb 9, 2024

Resolves #666


Before the change?

  • RequestError [HttpError]: Resource not accessible by integration

After the change?

  • RequestError [HttpError]: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#get-a-workflow-run

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Changing the length or format of opaque strings (eg IDs, error messages, other human-readable strings)


Copy link

github-actions bot commented Feb 9, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

src/fetch-wrapper.ts Outdated Show resolved Hide resolved
@wolfy1339 wolfy1339 merged commit dbfeab2 into octokit:main Feb 9, 2024
6 checks passed
Copy link

github-actions bot commented Feb 9, 2024

🎉 This PR is included in version 8.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jsoref jsoref deleted the add-documentation branch February 9, 2024 08:15
gr2m added a commit to octokit/auth-app.js that referenced this pull request Feb 13, 2024
renovate bot added a commit to octokit/auth-app.js that referenced this pull request Feb 13, 2024
* build(deps): lock file maintenance

* test: adapt tests for octokit/request.js#667

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Gregor Martynus <39992+gr2m@users.noreply.github.com>
Copy link

github-actions bot commented Apr 5, 2024

🎉 This PR is included in version 8.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEAT]: Include documentation_url in HttpError output
2 participants