build: fix test for signal option so it works across Node.js versions
#509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added this to Inbox
in 
timrogers
added
the
Type: Maintenance
1 task
oscard0m
requested changes
Aug 15, 2022
We test the `signal` option by passing in a value that isn't a signal and expecting `fetch` to throw an error. An error is thrown, but our current assertion doesn't work in Node.js v18 because the error message has changed. This changes the assertion to work with the behaviour of Node v14, v16 and v18.
timrogers
force-pushed
the
timrogers/signal-test
branch
from
1665950
to
4c923e3
Compare
oscard0m
approved these changes
Aug 15, 2022
|
🎉 This PR is included in version 6.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We test the
signaloption by passing in a value that isn't a signal and expectingfetchto throw an error.An error is thrown, but our current assertion doesn't work in Node.js v18 because the error message has changed. This changes the assertion to work with the behaviour of Node v14, v16 and v18.