Skip to content
This repository has been archived by the owner on Jul 27, 2020. It is now read-only.

Migration - Start an import: parameter type "url" should be "string" #65

Closed
gr2m opened this issue Mar 27, 2018 · 2 comments · Fixed by #109
Closed

Migration - Start an import: parameter type "url" should be "string" #65

gr2m opened this issue Mar 27, 2018 · 2 comments · Fixed by #109
Labels
bug Something isn't working as documented, or is being fixed

Comments

@gr2m
Copy link
Contributor

gr2m commented Mar 27, 2018

Current specification

{
"name": "Start an import",
"enabledForApps": true,
"method": "PUT",
"path": "/repos/:owner/:repo/import",
"params": [
{
"name": "owner",
"type": "string",
"required": true,
"description": ""
},
{
"name": "repo",
"type": "string",
"required": true,
"description": ""
},
{
"name": "vcs_url",
"type": "url",
"description": "**Required** The URL of the originating repository.",
"required": false
},
{
"name": "vcs",
"type": "enum",
"options": [
"subversion",
"git",
"mercurial",
"tfvc"
],
"description": "The originating VCS type. Can be one of `subversion`, `git`, `mercurial`, or `tfvc`. Please be aware that without this parameter, the import job will take additional time to detect the VCS type before beginning the import. This detection step will be reflected in the response.",
"required": false
},
{
"name": "vcs_username",
"type": "string",
"description": "If authentication is required, the username to provide to `vcs_url`.",
"required": false
},
{
"name": "vcs_password",
"type": "string",
"description": "If authentication is required, the password to provide to `vcs_url`.",
"required": false
},
{
"name": "tfvc_project",
"type": "string",
"description": "For a tfvc import, the name of the project that is being imported.",
"required": false
}
],
"description": "Start a source import to a GitHub repository using GitHub Importer.",
"documentationUrl": "https://developer.github.com/v3/migration/source_imports/#start-an-import"
}

I expected

"url" should be "string"
{
  "name": "Start an import",
  "enabledForApps": true,
  "method": "PUT",
  "path": "/repos/:owner/:repo/import",
  "params": [
    {
      "name": "owner",
      "type": "string",
      "required": true,
      "description": ""
    },
    {
      "name": "repo",
      "type": "string",
      "required": true,
      "description": ""
    },
    {
      "name": "vcs_url",
      "type": "string",
      "description": "**Required** The URL of the originating repository.",
      "required": false
    },
    {
      "name": "vcs",
      "type": "enum",
      "options": [
        "subversion",
        "git",
        "mercurial",
        "tfvc"
      ],
      "description": "The originating VCS type. Can be one of `subversion`, `git`, `mercurial`, or `tfvc`. Please be aware that without this parameter, the import job will take additional time to detect the VCS type before beginning the import. This detection step will be reflected in the response.",
      "required": false
    },
    {
      "name": "vcs_username",
      "type": "string",
      "description": "If authentication is required, the username to provide to `vcs_url`.",
      "required": false
    },
    {
      "name": "vcs_password",
      "type": "string",
      "description": "If authentication is required, the password to provide to `vcs_url`.",
      "required": false
    },
    {
      "name": "tfvc_project",
      "type": "string",
      "description": "For a tfvc import, the name of the project that is being imported.",
      "required": false
    }
  ],
  "description": "Start a source import to a GitHub repository using GitHub Importer.",
  "documentationUrl": "https://developer.github.com/v3/migration/source_imports/#start-an-import"
}

has failing test at #76

@gr2m gr2m added the bug Something isn't working as documented, or is being fixed label Mar 27, 2018
@gr2m gr2m added help wanted Contributions appreciated has-failing-test labels Mar 27, 2018
aryannarora added a commit to aryannarora/routes that referenced this issue Apr 13, 2018
@gr2m
Copy link
Contributor Author

gr2m commented Apr 13, 2018

@aryannarora is working on this at #76

@gr2m gr2m removed the help wanted Contributions appreciated label Apr 13, 2018
@gr2m gr2m closed this as completed in #109 Apr 13, 2018
@octokitbot
Copy link
Collaborator

🎉 This issue has been resolved in version 6.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working as documented, or is being fixed
Projects
None yet
2 participants