Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endpoints["PUT /user/starred/{owner}/{repo}"]["response"] returns never #254

Closed
gr2m opened this issue Feb 1, 2021 · 1 comment · Fixed by #255
Closed

Endpoints["PUT /user/starred/{owner}/{repo}"]["response"] returns never #254

gr2m opened this issue Feb 1, 2021 · 1 comment · Fixed by #255
Labels
Type: Bug Something isn't working as documented, or is being fixed
Projects
JS

Comments

@gr2m
Copy link
Contributor

gr2m commented Feb 1, 2021

What happened?

Endpoints["PUT /user/starred/{owner}/{repo}"]["response"] // never

What did you expect to happen?

Endpoints["PUT /user/starred/{owner}/{repo}"]["response"] // { status, url, headers, data: never }

What the problem might be

Must have been a recent change, the problem surfaced via octokit/request.js#352
@gr2m gr2m added the Type: Bug Something isn't working as documented, or is being fixed label Feb 1, 2021
@ghost ghost added this to Bugs in JS Feb 1, 2021
@gr2m gr2m mentioned this issue Feb 1, 2021
Merged
1 task
gr2m added a commit that referenced this issue Feb 1, 2021
@gr2m
fix: Endpoints["PUT /user/starred/{owner}/{repo}"]["response"] retu…
9230b50 
…rns `OctocitResponse` type

fixes #254
@gr2m gr2m mentioned this issue Feb 1, 2021
Merged
@gr2m gr2m closed this as completed in #255 Feb 1, 2021
JS automation moved this from Bugs to Done Feb 1, 2021
gr2m added a commit that referenced this issue Feb 1, 2021
@gr2m
fix: Endpoints["PUT /user/starred/{owner}/{repo}"]["response"] retu…
5091759 
…rns `OctocitResponse` type (#255)

fixes #254
@octokitbot
Copy link
Collaborator

🎉 This issue has been resolved in version 6.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something isn't working as documented, or is being fixed
Projects
No open projects
JS
  
Done
Milestone
No milestone
2 participants
@gr2m @octokitbot