Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POST /repos/{owner}/{repo}/forks has a never response type #271

Closed
eamodio opened this issue Feb 23, 2021 · 4 comments · Fixed by #272
Closed

POST /repos/{owner}/{repo}/forks has a never response type #271

eamodio opened this issue Feb 23, 2021 · 4 comments · Fixed by #272
Labels
Type: Bug Something isn't working as documented, or is being fixed
Projects
JS

Comments

@eamodio
Copy link
Contributor

eamodio commented Feb 23, 2021

It looks like because POST /repos/{owner}/{repo}/forks only has a 202 successful response, and 202 isn't part of the SuccessStatuses, it gets set to never.

See here:

types.ts/scripts/update-endpoints/templates/endpoints.ts.template

Line 75 in 6e5ea17

type SuccessStatuses = 200 | 201 | 204;

@eamodio eamodio added the Type: Bug Something isn't working as documented, or is being fixed label Feb 23, 2021
@ghost ghost added this to Bugs in JS Feb 23, 2021
@gr2m
Copy link
Contributor

gr2m commented Feb 23, 2021

Great catch & analysis! Would you like to send a pull request to fix it? You will have to update scripts/update-endpoints/templates/endpoints.ts.template and then run

npm run update-endpoints:typescript

In order for src/generated/Endpoints.ts to be updated.

@eamodio
Copy link
Contributor Author

eamodio commented Feb 23, 2021

Will do

eamodio added a commit to eamodio/types.ts that referenced this issue Feb 23, 2021
@eamodio
Fixes octokit#271 - adds 202 to SuccessStatuses
b480d7d
@eamodio eamodio mentioned this issue Feb 23, 2021
Merged
@eamodio
Copy link
Contributor Author

eamodio commented Feb 23, 2021

Opened #272

@gr2m gr2m closed this as completed in #272 Feb 23, 2021
JS automation moved this from Bugs to Done Feb 23, 2021
@octokitbot
Copy link
Collaborator

🎉 This issue has been resolved in version 6.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something isn't working as documented, or is being fixed
Projects
No open projects
JS
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: POST /repos/{owner}/{repo}/forks has a never response type eamodio/types.ts
3 participants
@gr2m @eamodio @octokitbot