New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): switch to esbuild #159
Conversation
I'm not sure why the browser tests are failing...
They are working fine on |
I don't know either, but I was able to reproduce it. Sorry I don't know out of what what might be the cause. When I paste the contents of |
got it 1a1d089 I wonder if there is a better way to do this, it will likely break again. We remove the exports because we don't want to import the file from another page, instead we want to evaluate all the code directly in the current blank page and then run our assertions. |
That is because puppeteer is no longer compatible with Node 14 |
🎉 This PR is included in version 3.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Pika has been deprecated for a while now, and the project has now been archived, and because of that the released npm package is missing most of the files generated by the build step.
Uses esbuild to transpile the TS source code into an ESM source, NodeJs bundle, and a browser bundle
Uses the TypeScript compiler to generate the types.
Behavior
Before the change?
dist-node
,dist-types
,dist-web
... even though they are generated correctly.After the change?
Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking change
label)If
Yes
, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: Bug
Type: Maintenance