Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document <event>.<action> where applicable #453

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

jablko
Copy link
Contributor

@jablko jablko commented Feb 8, 2021

Try to clarify where <event>.<action> is applicable, based on this suggestion #431 (comment):

Really it should say something like "One of Githubs supported event names, or (if the event has an action property) the name of an event followed by its action in form of <event>.<action>", and link here.


View rendered README.md

@ghost ghost added this to Inbox in JS Feb 8, 2021
@wolfy1339 wolfy1339 added documentation Type: Feature New feature or request labels Feb 8, 2021
@ghost ghost moved this from Inbox to Features in JS Feb 8, 2021
wolfy1339
wolfy1339 previously approved these changes Feb 8, 2021
@gr2m gr2m self-assigned this Mar 30, 2021
@ghost ghost moved this from Features to In progress in JS Mar 30, 2021
@gr2m
Copy link
Contributor

gr2m commented Mar 30, 2021

Thanks @jablko, sorry for the delay of getting it merged

@gr2m gr2m merged commit 437803c into octokit:master Mar 30, 2021
JS automation moved this from In progress to Done Mar 30, 2021
@github-actions
Copy link
Contributor

🎉 This PR is included in version 8.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
No open projects
JS
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants