Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Skipped to WorkflowRunConclusion #57

Merged
merged 1 commit into from Apr 27, 2022
Merged

Conversation

apmorton
Copy link
Contributor

We are seeing the following exceptions logged in an application using this framework:

System.Text.Json.JsonException: The JSON value 'skipped' could not be converted to Octokit.Webhooks.Models.WorkflowRunConclusion.

@JamieMagee JamieMagee enabled auto-merge (squash) April 27, 2022 16:04
@JamieMagee
Copy link
Contributor

Thanks for the contribution! I'll get this merged and cut a release.

@JamieMagee JamieMagee merged commit c3a41df into octokit:main Apr 27, 2022
@apmorton apmorton deleted the patch-1 branch April 27, 2022 16:28
wolfy1339 added a commit to octokit/webhooks that referenced this pull request Apr 28, 2022
wolfy1339 added a commit to octokit/webhooks that referenced this pull request Apr 28, 2022
* fix: add `waiting` state to `deployment_status`, `check_run` and `workflow_run` event
Ref: octokit/webhooks.net#52

* fix: add `skipped` to `workflow_run` conclusion
Ref: octokit/webhooks.net#57

* fix: update the `pull_request` property description on `check_run` event
* feat: add `pull_request_review_thread` examples,
The event was recently added to the docs

* feat(GHES): new event: `package`
* feat(GHES): new `pull_request_review_thread` event
* fix(GHES): event description updates
* feat(GHAE): new `pull_request_review_thread` event
* fix(GHAE): description updates
* feat: remove `secret_scanning_alert` from `index.json`

Co-authored-by: Octokit Bot <octokitbot@martynus.net>
Co-authored-by: wolfy1339 <webmaster@wolfy1339.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants