Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(CONTRIBUTING): add section on how to create schemas #645

Merged
merged 4 commits into from
Jun 21, 2022
Merged

docs(CONTRIBUTING): add section on how to create schemas #645

merged 4 commits into from
Jun 21, 2022

Conversation

wolfy1339
Copy link
Member

These are basic steps to creating a schema.
Fixes #643

@ghost ghost added this to Inbox in JS Jun 16, 2022
@wolfy1339 wolfy1339 added documentation Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR labels Jun 16, 2022
@ghost ghost moved this from Inbox to Maintenance in JS Jun 16, 2022
@wolfy1339
Copy link
Member Author

Blocked by #641, as the current cache has multiple entries for the new security_and_analysis event, and the index.json file didn't get generated in #634 which causes the tests to fail.

Would need to override the required tests for merge.

G-Rath
G-Rath reviewed Jun 16, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@wolfy1339 wolfy1339 changed the title docs: add section on how to create schemas in CONTRIBUTING.md docs(CONTRIBUTING): add section on how to create schemas in CONTRIBUTING.md Jun 20, 2022
@wolfy1339 wolfy1339 changed the title docs(CONTRIBUTING): add section on how to create schemas in CONTRIBUTING.md docs(CONTRIBUTING): add section on how to create schemas Jun 20, 2022
@wolfy1339 wolfy1339 marked this pull request as ready for review June 20, 2022 20:57
@wolfy1339
Copy link
Member Author

I believe this is ready to merge. (The test failures are unrelated to this PR)

gr2m
gr2m approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great, thank you so much for putting it together!

@gr2m gr2m merged commit dcd121e into master Jun 21, 2022
JS automation moved this from Maintenance to Done Jun 21, 2022
@gr2m gr2m deleted the creating-schemas-docs branch June 21, 2022 23:37
@oscard0m
Copy link
Member

Arrived late to the review but thanks for this @wolfy1339 ! ❤️ 👏🏽

@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

@G-Rath G-Rath G-Rath approved these changes

@oscard0m oscard0m Awaiting requested review from oscard0m

Assignees
No one assigned
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
No open projects
JS
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document how we get from a new webhook event to a new schema and to new types
5 participants
@wolfy1339 @oscard0m @octokitbot @gr2m @G-Rath