-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shows external repo when viewing local modules in Python #1366
Comments
Thanks for filling this issue. This is indeed a bug. Previously there was no option to handle such cases, but with the (not so new) architecture this should be possible with some work. Are you interested in working on a fix? I'm more than happy to guide you through the required changes. |
I'd love to, but I've never collaborated on a repo, so I'd need a couple of pointers.
…On Fri, Sep 24, 2021, 20:29 Stefan Buck ***@***.***> wrote:
Thanks for filling this issue. This is indeed a bug. Previously there was
no option to handle such cases, but with the (not so new) architecture this
should be possible with some work. Are you interested in working on a fix?
I'm more than happy to guide you through the required changes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1366 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGUI4P44TCVEFT45JUGKOBDUDS7SHANCNFSM5EUKL7UA>
.
|
Sorry, I'm a bit slow and quite busy right now. Starting next week I should have more time. In the meantime, please take a look at our End 2 End test guide. Maybe you're able to prepare a few test cases. |
I'll see what I can do! |
So I looked through the repo, and it seems like you already have test cases for Python on the better-python-support branch. How come they aren't merged with the main branch? |
Good shout. To be honest I haven't been very active on OctoLinker and I forgot about that PR. I'll have a look at the PR soon |
Expected Behavior
Given a file structure that looks like this:
Inspecting an import statement from a module should show the module in the current repo
What actually happened?
An external, public repository is linked instead of the local module.
URL
No response
Anything else we should know?
No response
The text was updated successfully, but these errors were encountered: