Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR #144 to add buffered stream appears to cause timeout issues. #145

Closed
LukeButters opened this issue May 12, 2022 · 0 comments · Fixed by #146
Closed

PR #144 to add buffered stream appears to cause timeout issues. #145

LukeButters opened this issue May 12, 2022 · 0 comments · Fixed by #146

Comments

@LukeButters
Copy link
Contributor

It looks like #144 has caused some timeout issues.

This was seen in the octopus server build.

A similar issues appears to occur when the buffer size is set to 40MB, that results in test StreamsCanBeSentToPolling() never terminating. To reproduce on windows disable net462.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Use a buffered stream for higher performance." OctopusDeploy/Halibut
1 participant
@LukeButters