Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to add link to pull request in release notes #44

Merged

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented Nov 1, 2021

Contents

New features

  • Add option to add link to pull request in release notes and make this the default behaviour

Testing

  • Move release notes compiler CLI tests to separate class

Quality Checklist

  • New features are fully tested (No matter how much Coverage Karma you have)
  • [v0.2 onward] New features are included in the documentation

@codecov-commenter
Copy link

Codecov Report

Merging #44 (271e847) into main (f642d40) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   96.49%   96.56%   +0.06%     
==========================================
  Files           3        3              
  Lines         257      262       +5     
==========================================
+ Hits          248      253       +5     
  Misses          9        9              
Impacted Files Coverage Δ
conventional_commits/compile_release_notes.py 95.31% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f642d40...271e847. Read the comment docs.

@cortadocodes cortadocodes self-assigned this Nov 1, 2021
@cortadocodes cortadocodes added the feature A new feature of the app label Nov 1, 2021
@cortadocodes cortadocodes linked an issue Nov 1, 2021 that may be closed by this pull request
@cortadocodes cortadocodes merged commit d8daaeb into main Nov 1, 2021
@cortadocodes cortadocodes deleted the feature/add-link-to-pull-request-in-release-notes branch November 1, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature of the app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to add link to relevant pull request in release notes
2 participants