Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLI #9

Closed
4 of 5 tasks
thclark opened this issue Sep 24, 2020 · 2 comments · Fixed by #26 or #25
Closed
4 of 5 tasks

Update CLI #9

thclark opened this issue Sep 24, 2020 · 2 comments · Fixed by #26 or #25
Assignees
Labels
feature A new feature of the app

Comments

@thclark
Copy link
Contributor

thclark commented Sep 24, 2020

Redesign CLI to a single CLI, instead of a mechanism that defines a new CLI for every app.

  • give an app path argument to specify which app to run
  • allow user to specify a --data-dir argument which, on instantiation of Analysis(), gives a hint to the location of sources which aren't specified on the command (allowing use straight from the terminal)
  • get version from git or from setup.py to remove the need for @octue_version decorator
  • remove deprecated logs directory
  • add CLI usage instructions to README
@thclark thclark added the quirk Quirky UX or styling problems that aren't major but reflect poorly on us label Sep 24, 2020
@thclark thclark added this to Triage in Twined Ecosystem Roadmap via automation Sep 24, 2020
@thclark thclark self-assigned this Sep 24, 2020
@thclark thclark changed the title move CLI version command to --version flag Update CLI Oct 27, 2020
@thclark thclark added architecture feature A new feature of the app and removed quirk Quirky UX or styling problems that aren't major but reflect poorly on us labels Oct 27, 2020
@cortadocodes cortadocodes linked a pull request Oct 28, 2020 that will close this issue
@cortadocodes
Copy link
Member

Requirements:

  1. We need to be able to find input and configuration datasets (i.e. a data path)
  2. We need to know where to write output datasets (i.e. a data path)
  3. We need to be able to read the manifest data (for configuration and inputs) from a src, which can be a file or raw json
  4. We need to be able to write the output manifest to a file (and need to know where that is)
  5. We need to be able to write the output_values to a file (and know where that is)

@cortadocodes
Copy link
Member

Based on conversation on 2020-10-31, I've removed this part of the issue: give input sources arguments (e.g. src can be a data path or a json string

@thclark thclark linked a pull request Nov 20, 2020 that will close this issue
13 tasks
@thclark thclark mentioned this issue Nov 20, 2020
13 tasks
Twined Ecosystem Roadmap automation moved this from Triage to Done Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature of the app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants