Skip to content

Conversation

@thclark
Copy link
Contributor

@thclark thclark commented Oct 27, 2020

New Features

  • Updated CLI to a central CLI rather than a generative process that gives a CLI for each application Update CLI #9
  • Updated dependencies of the fractal example for test with twined server (a tide-us-over stopgap)
  • Addition of a Pathable Class, which resolves discussions in Path management accessible from analysis #16 for managing paths
  • Adds a Context Manager for Datafiles which elegantly handles construction of data paths and opening of files in write mode Local file_like compatibility #3
  • Adds a complete example for use and creation of datasets via manifests.

Minor Changes

  • Various performance tuning and refactoring for simpler code by @cordatocodes
  • Negates need for Review: normalising path splitter respecting absolute paths #15 because Pathable uses the os.path builtins properly, to clean paths and resolve between absolute and relative
  • Serialisables can now exclude fields as well as explicitly including them
  • Style reapplied throughout (pre-commit didn't get installed)
  • Resolve issue Tests failing due to dependency #27 problem where the two tests of the run command of the CLI pass by themselves, but not when run in serial with test_fractal_configuration
  • Decision: Extra unused strand data should be passed to Runner to enable simplified CLI (see test_exception_raised_when_extra_strand_data_present)
  • [ x] Removes unused tmp_dir Remove tmp-dir #30

Still to do

  • monitors, children - to be done next release
  • Fix CLI raises TypeError when running from command - this should be fixed, but have yet to test the caller

@thclark thclark marked this pull request as draft October 27, 2020 19:47
@codecov-io
Copy link

codecov-io commented Nov 20, 2020

Codecov Report

Merging #25 (c2ebfb9) into main (95a1904) will increase coverage by 4.44%.
The diff coverage is 97.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   90.62%   95.07%   +4.44%     
==========================================
  Files          23       35      +12     
  Lines         448      629     +181     
==========================================
+ Hits          406      598     +192     
+ Misses         42       31      -11     
Impacted Files Coverage Δ
octue/mixins/identifiable.py 100.00% <ø> (ø)
octue/mixins/loggable.py 100.00% <ø> (ø)
octue/templates/template-python-fractal/app.py 100.00% <ø> (ø)
octue/cli.py 93.54% <88.88%> (+13.19%) ⬆️
octue/resources/manifest.py 87.87% <88.88%> (-3.43%) ⬇️
.../template-using-manifests/cleaner/read_dat_file.py 93.33% <93.33%> (ø)
octue/runner.py 92.30% <95.00%> (-5.37%) ⬇️
octue/__init__.py 100.00% <100.00%> (ø)
octue/definitions.py 100.00% <100.00%> (ø)
octue/mixins/__init__.py 100.00% <100.00%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95a1904...c2ebfb9. Read the comment docs.

@thclark thclark marked this pull request as ready for review November 20, 2020 22:48
@thclark thclark merged commit 08aa705 into main Nov 20, 2020
@thclark
Copy link
Contributor Author

thclark commented Nov 20, 2020

btw @cortadocodes if you haven't seen this, have a look, it's mega

And @AndyClifton you might be interested to see the issues list being destroyed over here

@cortadocodes cortadocodes deleted the release/0.1.4 branch January 6, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants