-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify manifest and dataset serialisation and add local metadata storage #402
Merged
cortadocodes
merged 59 commits into
main
from
enhancement/unify-dataset-path-and-cloud-path
Apr 6, 2022
Merged
Simplify manifest and dataset serialisation and add local metadata storage #402
cortadocodes
merged 59 commits into
main
from
enhancement/unify-dataset-path-and-cloud-path
Apr 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 25, 2022
BREAKING CHANGE: A datafile can no longer be added to a dataset as a set of kwargs in Dataset.add
BREAKING CHANGE: This removes the ability to provide multiple datafiles to Dataset.add as *args
cortadocodes
changed the title
Unify dataset path and cloud path
Simplify manifest and dataset serialisation and add local metadata storage
Mar 29, 2022
thclark
reviewed
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simplify manifest and dataset serialisation so their datasets' and files' metadata is gathered dynamically at instantiation instead of from hard-coded values in the serialisation. To allow this properly on both cloud and local platforms, the ability to store metadata locally has been introduced. This has also required the definition of a dataset to be tightened so that each dataset is either cloud-based or local, but not both.
Contents (#402)
IMPORTANT: There are 5 breaking changes.
New features
.octue
JSON file in the same directoryEnhancements
Dataset:
Dataset
serialisation to only include the paths to its files and its own metadata.octue
JSON file in its root directory instead ofdatafile_metadata.json
Pathable
mixinDataset.path
andDataset.cloud_path
Dataset.add
Manifest:
Manifest
serialisation to only include the paths to its datasets and its own metadataPathable
mixinpath
attributeOther:
Serialisable.to_primitive
as the basis forSerialisable.serialise
to simplify and speed up conversion to primitivesManifest.to_primitive
inAnalysis.finalise
Fixes
Dataset
andManifest
.octue
files when constructing datasetsDependencies
3.7
to3.7.1
pandas=^1.3
to avoidnumpy
array size errorstwined=0.3.0
Refactoring
Datafile
,Dataset
, andManifest
twined
intoRunner._validate_dataset_file_tags
Dataset
into separate method