Make Topic and Subscription classes standalone #523
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make the
Topic
andSubscription
classes standalone instead of relying on aService
instance and a related subscriber.Contents (#523)
IMPORTANT: There are 2 breaking changes.
Enhancements
service
argument fromTopic
constructorsubscriber
argument fromSubscription
constructorService
credentials from environment and removecredentials
attributeFixes
finally
clause to correct nesting level inOrderedMessageHandler.handle_messages
Upgrade instructions
💥 Remove `service` argument from `Topic` constructor
Provide the
project_name
argument instead of the oldservice
argument.💥 Remove `subscriber` argument from `Subscription` constructor
Remove the old
subscriber
argument as it's no longer needed.