Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic children override #524

Merged
merged 28 commits into from
Sep 29, 2022

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented Sep 27, 2022

Summary

Allow parents to override the default children its child uses (i.e. the parent's grandchildren). This allows services that produce the same type of results but use, for example, different versions of a model to be swapped in and out for each other without modifying the child.

Note that the child has to be running version 0.39.0 to be able to accept the override (otherwise it will just use its default children).

Contents (#524)

New features

  • Add ability to dynamically override a child's children when asking it a question

Enhancements

  • Use raw service IDs in logs and errors

Fixes

  • Use full service ID in MockService when answering question

Refactoring

  • Refactor OrderedMessageHandler methods into smaller methods

Testing

  • Remove middle-man ask_question_and_wait_for_answer method in TestService

@cortadocodes cortadocodes self-assigned this Sep 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2022

Codecov Report

Merging #524 (18f5156) into main (a87dd3d) will increase coverage by 0.21%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
+ Coverage   93.99%   94.21%   +0.21%     
==========================================
  Files          75       76       +1     
  Lines        3115     3180      +65     
==========================================
+ Hits         2928     2996      +68     
+ Misses        187      184       -3     
Impacted Files Coverage Δ
octue/cloud/emulators/child.py 97.64% <ø> (ø)
octue/configuration.py 92.30% <ø> (ø)
octue/resources/child.py 95.45% <ø> (ø)
octue/runner.py 92.22% <ø> (ø)
octue/cli.py 83.67% <43.75%> (-5.22%) ⬇️
octue/cloud/pub_sub/topic.py 94.33% <82.35%> (+0.86%) ⬆️
octue/cloud/pub_sub/subscription.py 91.42% <84.61%> (+3.92%) ⬆️
octue/cloud/pub_sub/message_handler.py 97.51% <98.18%> (+0.29%) ⬆️
...ctue/cloud/deployment/google/cloud_run/deployer.py 92.45% <100.00%> (-0.28%) ⬇️
octue/cloud/deployment/google/dataflow/pipeline.py 100.00% <100.00%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

docs/source/asking_questions.rst Outdated Show resolved Hide resolved
docs/source/asking_questions.rst Show resolved Hide resolved
octue/cloud/emulators/_pub_sub.py Outdated Show resolved Hide resolved
@cortadocodes cortadocodes changed the title Add dynamic children selection Add dynamic children override Sep 29, 2022
@cortadocodes cortadocodes merged commit 41931f6 into main Sep 29, 2022
@cortadocodes cortadocodes deleted the feature/add-dynamic-children-selection branch September 29, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants