Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cloud Run deployer and associated CLI command #580

Merged
merged 5 commits into from
Mar 23, 2023

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented Mar 23, 2023

Contents (#580)

IMPORTANT: There is 1 breaking change.

Operations

  • Add infrastructure needed to deploy example Cloud Run service

Testing

  • Test latest deployed version of cloud run example service
  • Test that app submodule log messages are handled

Reversions

  • 💥 BREAKING CHANGE: Remove Cloud Run deployer and associated CLI command

Upgrade instructions

💥 Remove Cloud Run deployer and associated CLI command

Use terraform to create the Google Cloud infrastructure needed and the Octue GitHub actions and workflows to set up automatic deployment to Cloud Run. See here for an example workflow and here for an example terraform config.

BREAKING CHANGE: Use terraform to create the Google Cloud infrastructure needed and the Octue GitHub actions and workflows to set up automatic deployment to Cloud Run.
@cortadocodes cortadocodes linked an issue Mar 23, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2023

Codecov Report

Merging #580 (0480962) into main (a87dd3d) will increase coverage by 0.42%.
The diff coverage is 94.67%.

@@            Coverage Diff             @@
##             main     #580      +/-   ##
==========================================
+ Coverage   93.99%   94.42%   +0.42%     
==========================================
  Files          75       78       +3     
  Lines        3115     3424     +309     
==========================================
+ Hits         2928     3233     +305     
- Misses        187      191       +4     
Impacted Files Coverage Δ
octue/cloud/deployment/google/dataflow/setup.py 0.00% <ø> (ø)
octue/essentials/monitor_messages.py 100.00% <ø> (ø)
octue/cli.py 86.44% <81.35%> (-2.45%) ⬇️
octue/app_loading.py 84.00% <84.00%> (ø)
octue/cloud/pub_sub/topic.py 94.44% <85.00%> (+0.96%) ⬆️
octue/cloud/pub_sub/subscription.py 91.54% <87.50%> (+4.04%) ⬆️
octue/resources/datafile.py 93.98% <88.23%> (-0.15%) ⬇️
octue/utils/testing.py 90.90% <90.90%> (ø)
octue/cloud/pub_sub/service.py 93.47% <92.20%> (+2.42%) ⬆️
octue/cloud/deployment/google/base_deployer.py 82.17% <92.85%> (-12.51%) ⬇️
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cortadocodes cortadocodes self-assigned this Mar 23, 2023
@cortadocodes cortadocodes merged commit 227f664 into main Mar 23, 2023
@cortadocodes cortadocodes deleted the reversion/remove-cloud-run-deployer branch March 23, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing deploy commands from CLI
2 participants