Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make crash diagnostics compatible with serialised datasets #585

Merged
merged 13 commits into from
Jun 27, 2023

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented Jun 27, 2023

Contents (#585)

Fixes

  • Ensure crash diagnostics can deal with serialised values
  • Ensure crash diagnostics can deal with manifests containing serialised datasets (as opposed to containing just paths to datasets)

Dependencies

  • Update requests and protobuf to avoid security issues

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2023

Codecov Report

Merging #585 (833cfe7) into main (a87dd3d) will increase coverage by 0.38%.
The diff coverage is 94.38%.

❗ Current head 833cfe7 differs from pull request most recent head bd9e4da. Consider uploading reports for the commit bd9e4da to get more accurate results

@@            Coverage Diff             @@
##             main     #585      +/-   ##
==========================================
+ Coverage   93.99%   94.38%   +0.38%     
==========================================
  Files          75       78       +3     
  Lines        3115     3436     +321     
==========================================
+ Hits         2928     3243     +315     
- Misses        187      193       +6     
Impacted Files Coverage Δ
octue/cloud/deployment/google/dataflow/setup.py 0.00% <ø> (ø)
octue/essentials/monitor_messages.py 100.00% <ø> (ø)
octue/cli.py 86.44% <81.35%> (-2.45%) ⬇️
octue/app_loading.py 84.00% <84.00%> (ø)
octue/cloud/pub_sub/topic.py 94.44% <85.00%> (+0.96%) ⬆️
octue/cloud/pub_sub/subscription.py 91.54% <87.50%> (+4.04%) ⬆️
octue/resources/datafile.py 93.98% <88.23%> (-0.15%) ⬇️
octue/utils/testing.py 90.90% <90.90%> (ø)
octue/cloud/pub_sub/service.py 93.47% <91.13%> (+2.42%) ⬆️
octue/cloud/deployment/google/base_deployer.py 82.17% <92.85%> (-12.51%) ⬇️
... and 25 more

@cortadocodes cortadocodes linked an issue Jun 27, 2023 that may be closed by this pull request
@cortadocodes cortadocodes self-assigned this Jun 27, 2023
@cortadocodes cortadocodes merged commit 331c074 into main Jun 27, 2023
5 checks passed
@cortadocodes cortadocodes deleted the fix/fix-crash-diagnostics-dict-error branch June 27, 2023 15:14
@cortadocodes cortadocodes changed the title Fix crash diagnostics dict error Make crash diagnostics compatible with serialised datasets Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash analytics failing to upload
2 participants