Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dataflow deployment CLI command #598

Merged
merged 8 commits into from Jul 26, 2023

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented Jul 14, 2023

Contents (#598)

IMPORTANT: There is 1 breaking change.

Operations

  • Remove unnecessary checkout steps in workflows
  • Run PR workflow on all PRs

Dependencies

  • Remove dataflow-related dependencies

Testing

  • Use live schema to test essential monitor messages

Reversions

  • 馃挜 BREAKING CHANGE: Remove octue deploy dataflow command and related code
  • Remove deployment-related attributes from ServiceConfiguration

Upgrade instructions

馃挜 Remove `octue deploy dataflow` command and related code

Use our deployment GitHub actions and workflows or contact us to deploy to Dataflow.

@codecov-commenter
Copy link

Codecov Report

Merging #598 (00c4697) into main (833cfe7) will decrease coverage by 0.03%.
The diff coverage is 93.49%.

@@            Coverage Diff             @@
##             main     #598      +/-   ##
==========================================
- Coverage   94.38%   94.35%   -0.03%     
==========================================
  Files          78       79       +1     
  Lines        3436     3509      +73     
==========================================
+ Hits         3243     3311      +68     
- Misses        193      198       +5     
Impacted Files Coverage 螖
octue/cli.py 86.44% <85.71%> (酶)
octue/cloud/pub_sub/service.py 93.08% <90.90%> (-0.40%) 猬囷笍
octue/cloud/service_id.py 95.50% <91.48%> (-4.50%) 猬囷笍
octue/crash_diagnostics.py 93.58% <93.58%> (酶)
...cloud/deployment/google/answer_pub_sub_question.py 87.50% <100.00%> (酶)
octue/cloud/deployment/google/base_deployer.py 82.17% <100.00%> (酶)
octue/cloud/deployment/google/dataflow/deployer.py 95.65% <100.00%> (酶)
octue/cloud/emulators/_pub_sub.py 93.10% <100.00%> (酶)
octue/cloud/pub_sub/message_handler.py 96.51% <100.00%> (酶)
octue/configuration.py 93.75% <100.00%> (+0.09%) 猬嗭笍
... and 4 more

@cortadocodes cortadocodes self-assigned this Jul 25, 2023
BREAKING CHANGE: Use our deployment GitHub actions and workflows or contact us to deploy to Dataflow.
@cortadocodes cortadocodes force-pushed the improve-monitor-message-tests branch from e856cd6 to eedd2f0 Compare July 25, 2023 14:43
@cortadocodes cortadocodes changed the title Use live schema to test essential monitor messages Remove dataflow deployment CLI command Jul 25, 2023
@cortadocodes cortadocodes linked an issue Jul 25, 2023 that may be closed by this pull request
@cortadocodes cortadocodes merged commit a6584c4 into main Jul 26, 2023
5 checks passed
@cortadocodes cortadocodes deleted the improve-monitor-message-tests branch July 26, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dataflow deployer?
2 participants