Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to automatically retry failed multiple questions #608

Merged
merged 18 commits into from Nov 13, 2023

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented Oct 4, 2023

Contents (#608)

IMPORTANT: There is 1 breaking change.

Enhancements

  • Add ability to automatically retry failed questions in Child.ask_multiple
  • Add Cloud Run dockerfile with python3.11 base

Operations

  • Use trusted publisher to publish to PyPi

Refactoring

  • 馃挜 BREAKING CHANGE: Remove deprecated code

Testing

  • Remove unnecessary service IDs from TestChild tests

Upgrade instructions

馃挜 Remove deprecated code
  • Use datafile.local_path instead of datafile.path
  • Use octue.utils.processes.run_logged_subprocess instead of octue.utils.threads.run_logged_subprocess

BREAKING CHANGE: Use `datafile.local_path` instead of `datafile.path`; use `octue.utils.processes.run_logged_subprocess` instead of `octue.utils.threads.run_logged_subprocess`
@cortadocodes cortadocodes linked an issue Oct 10, 2023 that may be closed by this pull request
@cortadocodes cortadocodes self-assigned this Oct 25, 2023
@nvn-nil
Copy link

nvn-nil commented Nov 1, 2023

@cortadocodes I have been using this branch in power-loss-service and it is working very well.

Perhaps we could think of some additional options to make it a bit more useful. Like:

  • max_retries - maximum number of times a question should be retried
  • prevent_retries_when: An exception or a tuple of exceptions that must not get retried if they are raised by the question/runner

We used to use a library called dramatiq for working with workers and async tasks and it had similar options. Dramatiq doc for reference here

Screenshot of the actor options section
image

@cortadocodes
Copy link
Member Author

That's great to hear @nvn-nil! Thanks for your feedback, I'll incorporate it and release soonish

@cortadocodes cortadocodes merged commit 384e5a1 into main Nov 13, 2023
5 checks passed
@cortadocodes cortadocodes deleted the support-automatic-question-retrying branch November 13, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide default dockerfiles with python3.10+ bases
2 participants