Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signed URL and child emulator bugs #621

Merged
merged 6 commits into from Dec 5, 2023
Merged

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented Dec 4, 2023

Contents (#621)

Fixes

  • Make Manifest.use_signed_urls_for_datasets idempotent
  • Ensure directories exist before downloading datafile from URL
  • Ensure child emulators can accept input manifests

@cortadocodes cortadocodes self-assigned this Dec 4, 2023
@cortadocodes cortadocodes changed the title Fix manifest bugs Fix data resource bugs Dec 5, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (833cfe7) 94.38% compared to head (19cfd4c) 95.03%.
Report is 125 commits behind head on main.

Files Patch % Lines
octue/crash_diagnostics.py 93.58% 5 Missing ⚠️
octue/cloud/service_id.py 92.72% 4 Missing ⚠️
octue/cli.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #621      +/-   ##
==========================================
+ Coverage   94.38%   95.03%   +0.65%     
==========================================
  Files          78       75       -3     
  Lines        3436     3322     -114     
==========================================
- Hits         3243     3157      -86     
+ Misses        193      165      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cortadocodes cortadocodes changed the title Fix data resource bugs Fix signed URL and child emulator bugs Dec 5, 2023
@cortadocodes cortadocodes merged commit 88c41ca into main Dec 5, 2023
6 checks passed
@cortadocodes cortadocodes deleted the fix-manifest-bugs branch December 5, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants