Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use updated twined #650

Merged
merged 18 commits into from May 7, 2024
Merged

Use updated twined #650

merged 18 commits into from May 7, 2024

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented Apr 25, 2024

Contents (#650)

IMPORTANT: There is 1 breaking change.

Enhancements

  • Include received invalid data in flask app error messages
  • Allow any iterable for Dataset files argument

Fixes

  • Ensure order argument is given in Service.send_exception
  • Add workaround for apparent bug in getting local metadata file's absolute path
  • Remove (now-) unnecessary json decoding in get_events

Dependencies

  • 💥 BREAKING CHANGE: Drop support for python3.7
  • Use twined==0.5.5
  • Update to black==24.4.2

Testing

  • Remove unnecessary test
  • Update asynchronous deployment test to accept numpy array as output values

Upgrade instructions

💥 Drop support for python3.7

Upgrade to python>=3.8 to keep using octue.

@cortadocodes cortadocodes self-assigned this Apr 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 94.47%. Comparing base (330ea82) to head (186e530).
Report is 8 commits behind head on main.

Files Patch % Lines
octue/utils/metadata.py 45.45% 6 Missing ⚠️
...cloud/deployment/google/answer_pub_sub_question.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #650      +/-   ##
==========================================
- Coverage   94.62%   94.47%   -0.16%     
==========================================
  Files          82       82              
  Lines        3552     3563      +11     
==========================================
+ Hits         3361     3366       +5     
- Misses        191      197       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cortadocodes cortadocodes changed the title Loosen twined dependency Use updated twined Apr 29, 2024
@cortadocodes cortadocodes linked an issue May 7, 2024 that may be closed by this pull request
@cortadocodes cortadocodes merged commit 450a280 into main May 7, 2024
5 checks passed
@cortadocodes cortadocodes deleted the upgrade-twined branch May 7, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop python3.7 support
2 participants