Fix missing attributes on Iconify provider

ocubom · Apr 3, 2023 · 64d07cc · 64d07cc
1 parent a3ea107
commit 64d07cc
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/src/Svg/Provider/Iconify/IconifyLoader.php b/src/Svg/Provider/Iconify/IconifyLoader.php
@@ -43,6 +43,8 @@ public function __construct(PathCollection $searchPath, iterable $options = null
         // Parse options
         $options = static::configureOptions()
             ->resolve(iterable_to_array($options ?? /* @scrutinizer ignore-type */ []));
+
+        // Check cache directory path
         $this->cacheDir = Path::canonicalize($options['cache_dir'] ?? '');
         if ('' === $this->cacheDir) {
             $this->cacheDir = null; // @codeCoverageIgnore
@@ -66,7 +68,7 @@ public function resolve(string $ident, iterable $options = null): Svg
             );
 
             if ($icon) {
-                return new Svg($icon->getSVG(iterable_to_array($options ?? [])));
+                return new Svg($icon->getSVG(iterable_to_array($options ?? []), true));
             }
         }
 

diff --git a/tests/Fixtures/filter/iconify-no-webcomponent.test b/tests/Fixtures/filter/iconify-no-webcomponent.test
@@ -35,8 +35,8 @@ return ['debug' => true]
     <body>
 
         <!-- Iconify SVG framework -->
-        <!--<span class="iconify" data-icon="mdi:home"></span>--><svg width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24" focusable="false" role="img" aria-hidden="true"><path fill="currentColor" d="M10 20v-6h4v6h5v-8h3L12 3L2 12h3v8h5Z" /></svg>
-        <!--<span class="iconify-inline" data-icon="mdi:home"></span>--><svg width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24" focusable="false" role="img" aria-hidden="true"><path fill="currentColor" d="M10 20v-6h4v6h5v-8h3L12 3L2 12h3v8h5Z" /></svg>
+        <!--<span class="iconify" data-icon="mdi:home"></span>--><svg class="iconify" data-icon="mdi:home" width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24" focusable="false" role="img" aria-hidden="true"><path fill="currentColor" d="M10 20v-6h4v6h5v-8h3L12 3L2 12h3v8h5Z" /></svg>
+        <!--<span class="iconify-inline" data-icon="mdi:home"></span>--><svg class="iconify-inline" data-icon="mdi:home" width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24" focusable="false" role="img" aria-hidden="true"><path fill="currentColor" d="M10 20v-6h4v6h5v-8h3L12 3L2 12h3v8h5Z" /></svg>
 
         <!-- Iconify Icon Web Component -->
         <iconify-icon icon="mdi:home"></iconify-icon>

diff --git a/tests/Fixtures/filter/iconify.test b/tests/Fixtures/filter/iconify.test
@@ -35,8 +35,8 @@ return ['debug' => true]
     <body>
 
         <!-- Iconify SVG framework -->
-        <!--<span class="iconify" data-icon="mdi:home"></span>--><svg width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24" focusable="false" role="img" aria-hidden="true"><path fill="currentColor" d="M10 20v-6h4v6h5v-8h3L12 3L2 12h3v8h5Z" /></svg>
-        <!--<span class="iconify-inline" data-icon="mdi:home"></span>--><svg width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24" focusable="false" role="img" aria-hidden="true"><path fill="currentColor" d="M10 20v-6h4v6h5v-8h3L12 3L2 12h3v8h5Z" /></svg>
+        <!--<span class="iconify" data-icon="mdi:home"></span>--><svg class="iconify" data-icon="mdi:home" width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24" focusable="false" role="img" aria-hidden="true"><path fill="currentColor" d="M10 20v-6h4v6h5v-8h3L12 3L2 12h3v8h5Z" /></svg>
+        <!--<span class="iconify-inline" data-icon="mdi:home"></span>--><svg class="iconify-inline" data-icon="mdi:home" width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24" focusable="false" role="img" aria-hidden="true"><path fill="currentColor" d="M10 20v-6h4v6h5v-8h3L12 3L2 12h3v8h5Z" /></svg>
 
         <!-- Iconify Icon Web Component -->
         <!--<iconify-icon icon="mdi:home"></iconify-icon>--><svg width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24" focusable="false" role="img" aria-hidden="true"><path fill="currentColor" d="M10 20v-6h4v6h5v-8h3L12 3L2 12h3v8h5Z" /></svg>