Add PR titles to UI #224
Merged
Add PR titles to UI #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocurrent fetches all the refs and PRs using the github graphql interface. The interface is abstracted out so we can get the title making another graphql query to github. It is not possible to just make one query because all the types are not exposed by OCurrent, so we would need to do a lot of copying of types if we wanted to avoid making another query.
gs0510
force-pushed
the
add_pr_titles
branch
from
3ea7767
to
cdb2492
Compare
|
|
|
|
|
Very nice! As a next step, this PR will allow us to update the sidebar as the preview proposed in #126 was looking really good! I think the current code doesn't update the missing PR titles for already processed commits (because the |
|
I think it would be nice to have the PR titles in the sidebar, as they would help navigation :) |
|
|
|
LGTM! Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ocurrent fetches all the refs and PRs using the github graphql interface. The interface is abstracted out so we can get the title
making another graphql query to github. It is not possible to just make one query because all the types are not exposed by OCurrent, so we would need to do a lot of copying of types if we wanted to avoid making another query. The frontend then displays the title if it's available in the benchmark_metadata table.