Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore NaNs when computing the mean #272

Merged
merged 2 commits into from
Jan 6, 2022

Conversation

punchagan
Copy link
Contributor

Previously, the mean included the count for the number of points, but ignored
NaN values. This seemed to make the mean value meaningless. This commit changes
the computation to completely ignore the mean values.

Previously, the mean included the count for the number of points, but ignored
NaN values. This seemed to make the mean value meaningless. This commit changes
the computation to completely ignore the mean values.
@punchagan punchagan requested review from art-w and gs0510 January 6, 2022 08:03
Copy link
Collaborator

@gs0510 gs0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks @punchagan!!

@gs0510 gs0510 merged commit 97c066a into ocurrent:main Jan 6, 2022
@punchagan punchagan deleted the fix-compute-mean branch January 6, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants